Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Workflow environment creation integration test #647

Merged

Conversation

Yossi-kerner
Copy link
Contributor

Issue & Steps to Reproduce / Feature Request

We want to prevent creating sub environments with the same workspace name and template name but since we can't explicitly set workspace name in the sub environment resource

Solution

have a workflow template with a single environment

Copy link
Contributor

@tomer-landesman tomer-landesman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, make sure to test with the new template before you merge it

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels May 8, 2023
@Yossi-kerner Yossi-kerner merged commit 57b174c into main May 8, 2023
4 checks passed
@Yossi-kerner Yossi-kerner deleted the fix-workflow-environment-creation-integration-test branch May 8, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix integration-tests ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants