Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: environment Role assignments for Team #668

Merged
merged 4 commits into from
Jul 5, 2023
Merged

Feat: environment Role assignments for Team #668

merged 4 commits into from
Jul 5, 2023

Conversation

TomerHeber
Copy link
Collaborator

Issue & Steps to Reproduce / Feature Request

resolves #654

Solution

  1. Added new API calls.
  2. Added unit tests for API calls.
  3. Created a new team environment assignment resource.
  4. Added acceptance tests.
  5. Added examples.
  6. Added integration tests.

@TomerHeber TomerHeber self-assigned this Jun 30, 2023
@TomerHeber TomerHeber requested a review from yaronya June 30, 2023 17:44
@TomerHeber
Copy link
Collaborator Author

Important note:

This is very similar to the user environment assignment (pretty much a copy-paste).
If another one comes along (an assignment) that is similar I'll merge it all together into a common code.
I can do it now as well if preferred.

yarivg
yarivg approved these changes Jul 3, 2023
View reviewed changes
Copy link

@yarivg yarivg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good!

examples/resources/env0_team_environment_assignment/resource.tf Outdated
resource "env0_custom_role" "custom_role" {
name = "custom-role-sample"
permissions = [
"VIEW_PROJECT",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change permissions to be ENVIRONMENT RELATED.. like view-env, edit-env-settings

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yarivg - could you please explain this comment?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I understand. Ignore please.

examples/resources/env0_workflow_triggers copy/resource.tf Outdated
resource "env0_custom_role" "custom_role" {
name = "custom-role-sample"
permissions = [
"VIEW_PROJECT",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change permissions to be ENVIRONMENT RELATED.. like view-env, edit-env-settings

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Jul 3, 2023
@TomerHeber TomerHeber merged commit 573d5cc into main Jul 5, 2023
4 checks passed
@TomerHeber TomerHeber deleted the feat-env-team-assg-#654 branch July 5, 2023 01:28
@razbensimon razbensimon mentioned this pull request Mar 13, 2024
Closed
@razbensimon razbensimon mentioned this pull request Apr 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarivg yarivg yarivg approved these changes

@yaronya yaronya Awaiting requested review from yaronya

Assignees

@TomerHeber TomerHeber

Labels
api-client examples feature integration-tests provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Environment Role assignments for User/Team
2 participants
@TomerHeber @yarivg