Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: env0_team_project_assignment doesn't support import #679

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

TomerHeber
Copy link
Collaborator

Issue & Steps to Reproduce / Feature Request

resolves #677

Solution

  1. Added import implementation to the resource.
  2. Added acceptance tests.
  3. Added an example for documentation.

Copy link
Contributor

@yaronya yaronya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall
Left a small question/request

Comment on lines +123 to +126
splitTeamProject := strings.Split(d.Id(), "_")
if len(splitTeamProject) != 2 {
return nil, fmt.Errorf("the id %v is invalid must be <team_id>_<project_id>", d.Id())
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add documentation for it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example is added:
examples/resources/env0_team_project_assignment/import.sh

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Jul 17, 2023
@TomerHeber TomerHeber merged commit c6efab2 into main Jul 17, 2023
9 checks passed
@TomerHeber TomerHeber deleted the feat-import-team-project-#677 branch July 17, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples feature provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

env0_team_project_assignment doesn't support import
2 participants