Chore: improve integration tests output and reduce noise #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerHeber
commented
Aug 15, 2023
| @@ -91,7 +94,7 @@ if err != nil { | |||
|
|
|||
| func ResourceGetFailure(resourceName string, d *schema.ResourceData, err error) diag.Diagnostics { | |||
| if frerr, ok := err.(*http.FailedResponseError); ok && frerr.NotFound() { | |||
| log.Printf("[WARN] Drift Detected: Terraform will remove %s from state", d.Id()) | |||
| tflog.Warn(ctx, "Drift Detected: Terraform will remove id from state", map[string]interface{}{"id": d.Id()}) | |||
There was a problem hiding this comment.
this is the only change...
the rest vscode plugin formatting the readme file.
TomerHeber
commented
Aug 15, 2023
| _, err := uuid.Parse(id) | ||
| if err == nil { | ||
| log.Println("[INFO] Resolving credentials by id: ", id) | ||
| tflog.Info(ctx, "Resolving credentials by id", map[string]interface{}{"id": id}) |
There was a problem hiding this comment.
Everything is now using tflog.
fmt.Printf has been deprecated.
TomerHeber
commented
Aug 15, 2023
| SetRetryCount(5). | ||
| SetRetryWaitTime(time.Second). | ||
| SetRetryMaxWaitTime(time.Second * 5). | ||
| OnBeforeRequest(func(c *resty.Client, r *resty.Request) error { | ||
| tflog.SubsystemInfo(subCtx, "env0_api_client", "Sending request", map[string]interface{}{"method": r.Method, "url": r.URL}) |
There was a problem hiding this comment.
some more logs.
TomerHeber
commented
Aug 15, 2023
| @@ -155,26 +155,37 @@ func configureProvider(version string, p *schema.Provider) schema.ConfigureConte | |||
| isIntegrationTest = true | |||
| } | |||
|
|
|||
| restyClient. | |||
| subCtx := tflog.NewSubsystem(ctx, "env0_api_client") | |||
There was a problem hiding this comment.
using a subcontext you can filter api_client logs by grep-ing "env0_api_client"
TomerHeber
commented
Aug 15, 2023
| tflog.SubsystemInfo(subCtx, "env0_api_client", "Received respose", map[string]interface{}{"method": r.Request.Method, "url": r.Request.URL, "status": r.Status()}) | ||
| return nil | ||
| }). | ||
| AddRetryAfterErrorCondition(). |
There was a problem hiding this comment.
This may have been needed to retry 4xx and 5xx.
Not sure... but worth checking it out if it helps (documentation isn't very clear).
There was a problem hiding this comment.
looking in the code... it's just:
c.AddRetryCondition(func(response *Response, err error) bool {
return response.IsError()
})
return c
}
but we'll try...
yaronya
approved these changes
Aug 17, 2023
github-actions
bot
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
Solution