Fix: env0_agent_values data source doesn't fetch values #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerHeber
commented
Aug 15, 2023
|
|
||
| return client.httpResult(result, err) | ||
| } else { | ||
| return client.httpResult(request.SetResult(response).Get(path)) |
There was a problem hiding this comment.
normal use-case (regular code) - uses built-in SetResult.
TomerHeber
commented
Aug 15, 2023
| responseType := reflect.TypeOf(response) | ||
|
|
||
| if responseType.Kind() == reflect.Ptr && responseType.Elem().Kind() == reflect.String { | ||
| responseStrPtr := response.(*string) |
There was a problem hiding this comment.
handles the string pointer use-case.
TomerHeber
commented
Aug 15, 2023
amit-alkobi-env0
approved these changes
Aug 16, 2023
github-actions
bot
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
fixes #690
Solution
resty does not play nice with non-struct values.
had to manually handle the string pointer use-case.