Fix: 'endless drift' when setting template path to start with '/' #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerHeber
commented
Aug 27, 2023
| pathPrefix = prefix + ".0.path" | ||
| } | ||
|
|
||
| path, pathOk := d.GetOk(pathPrefix) |
There was a problem hiding this comment.
save the current value
TomerHeber
commented
Aug 27, 2023
| } | ||
|
|
||
| path, pathOk := d.GetOk(pathPrefix) | ||
|
|
||
| if err := writeResourceDataEx(prefix, &template, d); err != nil { |
There was a problem hiding this comment.
this updated to the new value
TomerHeber
commented
Aug 27, 2023
| if err := writeResourceDataEx(prefix, &template, d); err != nil { | ||
| return fmt.Errorf("schema resource data serialization failed: %v", err) | ||
| } | ||
|
|
||
| // https://github.com/env0/terraform-provider-env0/issues/699 - backend removes the "/". | ||
| if pathOk && path.(string) == "/"+template.Path { |
There was a problem hiding this comment.
if diff is just in "/" revert to old path - this avoids a drift and keeps state intact with what the user entered.
TomerHeber
commented
Aug 27, 2023
| @@ -1006,6 +1006,84 @@ func TestUnitTemplateResource(t *testing.T) { | |||
| }) | |||
| }) | |||
|
|
|||
| // https://github.com/env0/terraform-provider-env0/issues/699 | |||
| t.Run("path drift", func(t *testing.T) { | |||
There was a problem hiding this comment.
test fails without the fix.
alonnoga
approved these changes
Aug 29, 2023
github-actions
bot
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
fixes #699
Solution
Keeping the state with "/" to avoid endless drift. Ignoring the value returned by the template if only "/" was omitted.
Added an acceptance test for this use-case and updated the integration test.