Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add new OIDC credentials creation and assigment (AWS data source) #759

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Feat: add new OIDC credentials creation and assigment (AWS data source) #759

merged 4 commits into from
Dec 4, 2023

Conversation

TomerHeber
Copy link
Collaborator

@TomerHeber TomerHeber commented Nov 30, 2023 •
edited
Loading

Solution

Part of #743

  1. Added data source.
  2. Added required API for oidc sub.
  3. Added unit tests for API call.
  4. Added acceptance tests for new data source.
  5. Added integration tests for new data source. --- removed --- flaky due to oicd policy enablement.
  6. Added examples.

@TomerHeber TomerHeber self-assigned this Nov 30, 2023
@tomer-landesman
Copy link
Contributor

Init Remote Apply step is not looking for the right flag

Yossi-kerner
Yossi-kerner reviewed Dec 3, 2023
View reviewed changes
Copy link
Contributor

@Yossi-kerner Yossi-kerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all looks good left some questions. Also I need some more explanation about the last 3 tests in env0/data_aws_oidc_credentials_test.go

client/api_key.go Show resolved Hide resolved
env0/data_aws_oidc_credentials_test.go Show resolved Hide resolved
@TomerHeber
Copy link
Collaborator Author

All in all looks good left some questions. Also I need some more explanation about the last 3 tests in env0/data_aws_oidc_credentials_test.go

@Yossi-kerner added some comments and responded to your questions. Please let me know if further information is required. Thank you!

Yossi-kerner
Yossi-kerner approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@Yossi-kerner Yossi-kerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Dec 4, 2023
@TomerHeber TomerHeber merged commit 008ccd8 into main Dec 4, 2023
4 checks passed
@TomerHeber TomerHeber deleted the feat-aws-oidc-data-#743 branch December 4, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yossi-kerner Yossi-kerner Yossi-kerner approved these changes

@yaronya yaronya Awaiting requested review from yaronya

Assignees

@TomerHeber TomerHeber

Labels
api-client examples feature provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TomerHeber @tomer-landesman @Yossi-kerner