Feat: add new OIDC credentials creation and assigment (Azure data sou… #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerHeber
commented
Dec 25, 2023
| @@ -29,8 +29,6 @@ func TestAwsOidcCredentialDataSource(t *testing.T) { | |||
| Type: string(client.AwsAssumedRoleCredentialsType), | |||
| } | |||
|
|
|||
| oidcSub := "oidc sub 123345 !!!" | |||
There was a problem hiding this comment.
moved to organization data.
TomerHeber
commented
Dec 25, 2023
| "github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource" | ||
| ) | ||
|
|
||
| func TestAzureOidcCredentialDataSource(t *testing.T) { |
There was a problem hiding this comment.
tests duplication to be refactored on the next commit.
TomerHeber
commented
Dec 25, 2023
| @@ -49,5 +54,10 @@ func dataOrganizationRead(ctx context.Context, d *schema.ResourceData, meta inte | |||
| return diag.Errorf("schema resource data serialization failed: %v", err) | |||
| } | |||
|
|
|||
| oidcSub, err := apiClient.OidcSub() | |||
| if err == nil { | |||
There was a problem hiding this comment.
may fail if oidc is disabled. Set the value if successful.
Yossi-kerner
approved these changes
Dec 26, 2023
github-actions
bot
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rce)
Part of #743
Solution