Chore: add soft delete to configuration variable #866
Conversation
| @@ -110,6 +110,11 @@ func resourceConfigurationVariable() *schema.Resource { | |||
| Description: "the value of this variable must match provided regular expression (enforced only in env0 UI)", | |||
| Optional: true, | |||
| }, | |||
| "soft_delete": { | |||
There was a problem hiding this comment.
@TomerHeber now that I think about it we could have added it to "environment import resource" as well so that it won't be implicit that its not actually deleted
| "soft_delete": { | ||
| Type: schema.TypeBool, | ||
| Description: "soft delete the configuration variable, once removed from the configuration it won't be deleted from env0", | ||
| Optional: true, |
There was a problem hiding this comment.
Please add a default value. This prevents many issues with bool types.
There was a problem hiding this comment.
what are the issues?
| @@ -237,6 +242,11 @@ func resourceConfigurationVariableUpdate(ctx context.Context, d *schema.Resource | |||
| } | |||
|
|
|||
| func resourceConfigurationVariableDelete(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics { | |||
| // don't delete if soft delete is set | |||
| if softDelete, ok := d.GetOk("soft_delete"); ok && softDelete.(bool) { | |||
There was a problem hiding this comment.
If you put a default you can just get the softDelete.
GetOk does not work properly with booleans...
| "soft_delete": { | ||
| Type: schema.TypeBool, | ||
| Description: "soft delete the configuration variable, once removed from the configuration it won't be deleted from env0", | ||
| Optional: true, |
There was a problem hiding this comment.
same here - please add a default.
env0/resource_environment_import.go
Outdated
| func resourceEnvironmentImportDelete(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics { | ||
| // don't delete if soft delete is set | ||
| if softDelete, ok := d.GetOk("soft_delete"); ok && softDelete.(bool) { |
There was a problem hiding this comment.
same here.. once you have a default.. just get the value...
…onfiguration-variables-on-removal-#856
| @@ -58,6 +58,12 @@ func resourceEnvironmentImport() *schema.Resource { | |||
| Description: "iac version of the environment", | |||
| Optional: true, | |||
| }, | |||
| "soft_delete": { | |||
| Type: schema.TypeBool, | |||
| Description: "soft delete the configuration variable, once removed from the configuration it won't be deleted from env0", | |||
There was a problem hiding this comment.
Is this comment correct? default is false...
There was a problem hiding this comment.
yeah if they set the field ( to true ) it won't delete
I just defaulted it to false so it won't be set by default ( we want soft delete to be explicit )
we generate the code that uses these flags so we'll just set soft_delete = true we don't really expect customers to use those flags, but we just didn't want the resource to act in unexpected ways without it being explicit
|
@TomerHeber please also see this commit 22a1e2e |
…onfiguration-variables-on-removal-#856
github-actions
bot
added
ready to merge
alonnoga
deleted the
chore-add-a-flag-for-not-actually-deleting-configuration-variables-on-removal-#856
branch
Issue & Steps to Reproduce / Feature Request
Part of :#856
We need to be able to remove configuration variables from code without actually deleting them
In environment import we initialize variables for the user to review and create an environment from
These resources are not expected to be committed, managed other then applying them once, so we need them to not be removed once the configuration is removed
Edit:
After adding a soft delete flag to config variable it I realized we should have added one to env import resource to make this strange behavior explicit 👍🏻 ( So I added that as well )