chore: add tests for sshkey (resource + data) #94
Conversation
razbensimon
force-pushed
the
chore-sskey-resource-test
branch
from
92d1827
to
c71a999
Compare
razbensimon
changed the title
| Check: resource.ComposeAggregateTestCheckFunc( | ||
| resource.TestCheckResourceAttr(resourceFullName, "id", sshKey.Id), | ||
| resource.TestCheckResourceAttr(resourceFullName, "name", sshKey.Name), | ||
| resource.TestCheckResourceAttr(resourceFullName, "value", sshKey.Value), |
There was a problem hiding this comment.
@razbensimon So the decrypted ssh key exists on the returned object? 🤔
There was a problem hiding this comment.
this is the resource, not the data tests
There was a problem hiding this comment.
Yeah but still, I get that it should be a part of the SshKeyCreatePayload but I'm not sure it should be a part of the ssh key schema because nobody uses it and it's a secret value. WDYT? (shouldn't be on this PR btw)
There was a problem hiding this comment.
put sensitive for now, and lets talk with the team
| "testing" | ||
| ) | ||
|
|
||
| func TestUnitSshKeyDataSourceById(t *testing.T) { |
There was a problem hiding this comment.
It really feels like we can DRY those two test functions. I think it's worth an effort 🙏
env0/data_sshkey_test.go
Outdated
| } | ||
|
|
||
| runUnitTest(t, testCase, func(mock *client.MockApiClientInterface) { | ||
| mock.EXPECT().SshKeys().AnyTimes().Return([]client.SshKey{sshKey}, nil) |
There was a problem hiding this comment.
Can we try to be more specific with .Times(1)?
This is also relevant for all other tests
There was a problem hiding this comment.
20f7ef7
worked only for resource tests file. data must have AnyTimes from some reason
There was a problem hiding this comment.
Can you tell maybe how many times it runs? (you can check out using debugger).
I'm asking because it's important to understand this tho.If it's only two - we can add a setting that prevents the second time from running so we'd be able to assert the number of calls easily.
There was a problem hiding this comment.
where do you see it on the debugger? what line
env0/resource_sshkey_test.go
Outdated
| } | ||
|
|
||
| runUnitTest(t, testCase, func(mock *client.MockApiClientInterface) { | ||
| mock.EXPECT().SshKeyCreate(client.SshKeyCreatePayload{Name: sshKey.Name, Value: sshKey.Value}).Times(1).Return(sshKey, nil).Return(sshKey, nil) |
There was a problem hiding this comment.
@razbensimon You got a redundant Return() call here 🙊
Issue & Steps to Reproduce / Feature Request
Solution