Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid tf files in subfolders #64

Merged
merged 3 commits into from Oct 21, 2020

Conversation

shlomimatichin
Copy link
Contributor

fixes #43

Copy link
Contributor

@yaronya yaronya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine n' easy, but I got some comments:

  1. Should we have the folder name marked with the issue number? and not use case? 🤔
  2. We probably need to have test files also for Terraform 11 + 12.
  3. Looks like CI github actions did not run (?), but I think it'd fail the aws_submodule test since we wouldn't parse any of the included .tf files.
    I'd suggest to move the parent.tf file to be a main.tf file under root folder.

@roni-frantchi
Copy link
Contributor

CI fixed.
@shlomimatichin you're welcome to take a look at the rest of @yaronya 's comments

@shlomimatichin
Copy link
Contributor Author

@yaronya

  1. i've put both in the name. i think it helps to be able to read why that test was originally there.
  2. i don't see much value in that. repeating the test does not add coverage, it's not really about the differences between the versions, unlike other cases. at least in past projects i've reached "too much tests" position, so i'm not excited to recreate that again. at any case, if you still think this should block merging, lmk, i'll duplicate the test.

@yaronya yaronya merged commit d0b9eaa into env0:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unused files get parsed
3 participants