-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Rubocop #51
Upgrade Rubocop #51
Conversation
Thanks @johnsyweb. 👍 Looks like there are a few more cops to satisfy. |
.travis.yml
Outdated
@@ -6,4 +6,3 @@ rvm: | |||
- 2.2.4 | |||
- 2.1.8 | |||
- 2.0.0 | |||
- 1.9.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly controversial.
.travis.yml
Outdated
@@ -6,4 +6,3 @@ rvm: | |||
- 2.2.4 | |||
- 2.1.8 | |||
- 2.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubocop fails for this (EOL) version. Shall we can it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove it.
Thanks @johnsyweb |
Context
The rubocop dependency defined in pagerduty.gemspec has a known low severity security vulnerability in version range < 0.48.1 and should be updated.
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-8418
Change
rubocop
Cc
@orien