Adopt PagerDuty's new API 2.0

[reidcooper]

Starting April 28th, PagerDuty will stop issuing API tokens for their v1 API service.

On October 19th, PagerDuty will decommission their v1 API service.

https://v2.developer.pagerduty.com/docs/v1-rest-api-decommissioning-faq

I have adapted the current gem code to support the new syntax of PagerDuty's API v2 service.

[majormoses]

Will try to give it a more thorough review some time this weekend when I have had a chance to read through the changes in the api docs but from a quick look everything made sense.

[orien]

Thanks @reidcooper. It looks like a lot of work went into this!

I think it's important to point out that this gem uses the Events API, not the Rest API. V1 of the Events API is not deprecated and will be available post October 19, as noted in the FAQ.

WILL THE V1 EVENTS API STILL BE SUPPORTED?
This change only affects the v1 REST API. You can continue to use the v1 Events API as you do today.

I'm concerned about introducing a backwards incompatible change. Are we able to support both Pagerduty Event versions in some way?

[majormoses]

@orien good catch on the events api still gonna be accessible, I did see that a v1 token should still be possible against a v2 api. I think in light of this we could make new v2 methods and have them opt-in on the integration side preventing a breaking change while allowing projects to upgrade to newer APIs for longer term support as I imagine that they won't keep the events v1 API around forever. It's a bit more work but I think it might be worth it since there is no immediate need to update to keep things working.

[majormoses]

I think we should look at doing this as there are things that can't be set in v1 api such as Severity that defaults to Critical for all events that do not have it attached.

https://v2.developer.pagerduty.com/docs/events-api-v2

[reidcooper]

Yes. That is the real reason why I did the upgrade. The Severity level is something we wanted to do to help set priorities based on major alerts.

…

On Oct 19, 2018, at 11:31 AM, Ben Abrams ***@***.***> wrote: I think we should look at doing this as there are things that can't be set in v1 api such as Severity that defaults to Critical for all events that do not have it attached. https://v2.developer.pagerduty.com/docs/events-api-v2 <https://v2.developer.pagerduty.com/docs/events-api-v2> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#52 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGmcPXXxp-oZa6xNmR61KNa5Si9fmlAaks5umfBWgaJpZM4TatXb>.

[reidcooper]

I am going to close this PR. Feel free to use my branch in the future :) Keep up the great work :)

[orien]

Thanks for the contribution @reidcooper. I'll use this as a base, but with additions to maintain backwards compatibility.