Use GitHub Actions for the CI build #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orien
commented
Dec 17, 2020
Comment on lines
+7
to
+12
|
|
||
| group :test do | ||
| if Gem::Version.new(RUBY_VERSION) < Gem::Version.new("2.6") | ||
| gem "rspec-given", "< 3.8.1" | ||
| end | ||
| end |
There was a problem hiding this comment.
It seems later versions of rspec-given are not compatible with Ruby prior to version 2.6.
The Gemfile is not included in the released gem, or influence its content, so configuring this here will only help in development and CI environments.
orien
changed the title
johnsyweb
reviewed
Dec 17, 2020
| - 2.1 | ||
| - 2.2 | ||
| - 2.3 | ||
| - 2.4 |
There was a problem hiding this comment.
Is now a good time to remove support for EOL rubies?
There was a problem hiding this comment.
(I've been doing the same for Rack::ECG)
There was a problem hiding this comment.
This library isn't using any new features introduced in later Rubies. Until we need to do so, I don't have a strong incentive to remove support.
liamdawson
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate from Travis CI to GitHub Actions for the CI build.