Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added type parameter to FieldGroup #85

Merged
merged 2 commits into from
Dec 11, 2019
Merged

Added type parameter to FieldGroup #85

merged 2 commits into from
Dec 11, 2019

Conversation

maschino
Copy link
Member

@maschino maschino commented Dec 11, 2019 •
edited
Loading

Summary

This PR makes the FieldGroup generic. Closes #10

Checklist

Please ensure that you've fulfilled the following tasks:

  • My code follows the style guides of this project and yarn lint does not throw errors
  • My code is well tested and did not decrease the test coverage
  • All new and existing tests have passed
  • My submission passes the build
  • I've added changes to CHANGELOG.MD
  • I've updated the project documentation

@maschino maschino added enhancement New feature or request FieldGroup Issues regarding FieldGroups labels Dec 11, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 768

  • 7 of 7 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 763: 0.0%
Covered Lines: 603
Relevant Lines: 603
💛 - Coveralls

@maschino maschino merged commit 74746f1 into master Dec 11, 2019
@maschino maschino deleted the feature/typesafe-fieldgroup branch December 11, 2019 20:46
maschino added a commit to maschino/react-ocean-forms that referenced this pull request Mar 28, 2020
@maschino
Merge pull request environment-agency-austria#85 from environment-age…
03b1be8 
…ncy-austria/feature/improved-validation-summary

Improved validation summary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request FieldGroup Issues regarding FieldGroups
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Type safety to FieldGroup
2 participants
@maschino @coveralls