Add vars eqs #22
Merged
Add vars eqs #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirikuncar
reviewed
Jun 26, 2017
essm/equations/_core.py
Outdated
| """Equation interface.""" | ||
| """Equation interface. | ||
|
|
||
| :raises ValueError: if the message_body exceeds 160 characters |
There was a problem hiding this comment.
@schymans can you please update the docstring?
jirikuncar
reviewed
Jun 26, 2017
| @@ -85,3 +85,7 @@ Physics | |||
|
|
|||
| .. automodule:: essm.equations.physics.thermodynamics | |||
| :members: | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
We should add new section here ...
|
@schymans I have changed the base branch from |
jirikuncar
reviewed
Jun 26, 2017
essm/equations/_core.py
Outdated
| @@ -31,7 +31,55 @@ | |||
|
|
|||
|
|
|||
| class EquationMeta(type): | |||
| """Equation interface.""" | |||
| """Equation interface. Defines an equation with a docstring | |||
There was a problem hiding this comment.
$ pydocstyle essm
essm/equations/_core.py:33 in public class `EquationMeta`:
D301: Use r""" if any backslashes in a docstring
essm/equations/_core.py:33 in public class `EquationMeta`:
D400: First line should end with a period (not 'g')
essm/equations/_core.py:33 in public class `EquationMeta`:
D205: 1 blank line required between summary line and description (found 0)
essm/equations/_core.py:33 in public class `EquationMeta`:
D300: Use """triple double quotes""" (found """-quotes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to EquationWriter and added test to make sure that the file generated is importable.