added .free_symbols to Variable. #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed in SymPy. |
…e_unit due to error.
|
@schymans can you try to rebase on top of master? I am not really sure how to resolve some of the conflicts. |
|
I thought I had! I'll check again. I actually realised that Quantities are not returned as free symbols in Sympy, so the current behaviour is consistent. I am now creating some functions in utils.py to achieve what I wanted originally. Therefore, I'll close this PR and start a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the
.free_symbolsmethod on physical variables and equations returns{}. This PR should give a dictionary of physical variables in an equation or expression.