Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Adding complete feature to members page #104

Merged
merged 5 commits into from
Mar 2, 2023
Merged

WIP: Adding complete feature to members page #104

merged 5 commits into from
Mar 2, 2023

Conversation

dahal
Copy link
Member

@dahal dahal commented Feb 15, 2023 •
edited

Feature

This PR will has a complete member invite flow

Changes proposed

  • When maintainer or an admin invites a user
  • Add them to ProjectInvite table
  • Do not create user record yet
  • Send them an email with invitation link and passphrase
  • This passphrase will be encrypted before its saved on database
  • Invited user then copies this passphrase and clicks on invitation link
  • They will be asked to provide this passphrase.
  • On success, create a user record ask them to go to /auth url to authenticate.

Few additional things we need to make sure for this PR

  • This PR should enhance audit log with invite/accept flow
  • This PR will render all the active team members on table
  • This PR will render all pending and inactive team members
  • This PR should make team members searchable based on different tabs.

Screenshots

Note to reviewers

@dahal dahal marked this pull request as draft February 15, 2023 06:52
@dahal dahal self-assigned this Feb 15, 2023
@dahal dahal added the 🚀 feature New feature or request label Feb 15, 2023
@dahal dahal marked this pull request as ready for review March 2, 2023 07:13
@dahal dahal force-pushed the feat/more-to-members-page branch from 78facd6 to 08ed38f Compare March 2, 2023 07:17
@socket-security
Copy link

Socket Security Pull Request Report

Dependency issues detected: If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 Install scripts

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Package Script field Source
argon2@0.30.3 (added) install package.json
bcrypt@5.1.0 (added) install package.json via mailing@0.9.10
🫣 Native code

Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs.

Ensure that native code bindings are expected. Consumers may consider pure JS and functionally similar alternatives to avoid the challenges and risks associated with native code bindings.

Package Location Source
argon2@0.30.3 (added) binding.gyp package.json
⚠️ URL strings

Package contains fragments of external URLs or IP addresses, which may indicate that it covertly exfiltrates data.

Avoid using packages that make connections to the network, since this helps to leak data.

Package URL Fragment Location Source
moment@2.29.4 (added) http://momentjs.com/guides/#/warnings/min-max/ src/lib/moment/min-max.js package.json
moment@2.29.4 (added) http://momentjs.com/guides/#/warnings/min-max/ src/lib/moment/min-max.js package.json
date-fns@2.29.3 (added) HH.mm.ss esm/locale/fi/_lib/formatLong/index.js package.json
date-fns@2.29.3 (added) HH.mm.ss esm/locale/id/_lib/formatLong/index.js package.json
date-fns@2.29.3 (added) HH.mm.ss esm/locale/id/_lib/formatLong/index.js package.json
date-fns@2.29.3 (added) HH.mm.ss esm/locale/ms/_lib/formatLong/index.js package.json
date-fns@2.29.3 (added) HH.mm.ss esm/locale/ms/_lib/formatLong/index.js package.json
date-fns@2.29.3 (added) HH.mm.ss locale/fi/_lib/formatLong/index.js package.json
dayjs@1.11.7 (added) HH.mm.ss esm/locale/fi.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm.ss esm/locale/id.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm.ss esm/locale/jv.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm.ss esm/locale/ms-my.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm.ss esm/locale/ms.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm.ss esm/locale/sv-fi.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm.ss esm/locale/tzl.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm.ss locale/fi.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm.ss locale/id.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm.ss locale/jv.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm.ss locale/ms-my.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm.ss locale/ms.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm.ss locale/sv-fi.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm.ss locale/tzl.js package.json via cypress@12.5.1
moment@2.29.4 (added) HH.mm.ss dist/locale/id.js package.json
moment@2.29.4 (added) HH.mm.ss dist/locale/jv.js package.json
moment@2.29.4 (added) HH.mm.ss dist/locale/ms-my.js package.json
moment@2.29.4 (added) HH.mm.ss locale/fi.js package.json
moment@2.29.4 (added) HH.mm.ss locale/id.js package.json
moment@2.29.4 (added) HH.mm.ss locale/jv.js package.json
moment@2.29.4 (added) HH.mm.ss locale/ms-my.js package.json
moment@2.29.4 (added) HH.mm.ss locale/ms.js package.json
moment@2.29.4 (added) HH.mm.ss locale/tzl.js package.json
moment@2.29.4 (added) HH.mm.ss min/locales.min.js package.json
moment@2.29.4 (added) HH.mm.ss min/locales.min.js package.json
moment@2.29.4 (added) HH.mm.ss min/locales.min.js package.json
moment@2.29.4 (added) HH.mm.ss min/locales.min.js package.json
moment@2.29.4 (added) HH.mm.ss min/locales.min.js package.json
moment@2.29.4 (added) HH.mm.ss min/locales.min.js package.json
moment@2.29.4 (added) HH.mm.ss src/locale/id.js package.json
moment@2.29.4 (added) HH.mm.ss src/locale/jv.js package.json
moment@2.29.4 (added) HH.mm.ss src/locale/ms-my.js package.json
date-fns@2.29.3 (added) https://github.com/date-fns/date-fns/blob/master/docs/upgradeGuide.md#string-arguments esm/toDate/index.js package.json
date-fns@2.29.3 (added) HH.mm esm/locale/fi/_lib/formatLong/index.js package.json
date-fns@2.29.3 (added) HH.mm esm/locale/id/_lib/formatLong/index.js package.json
date-fns@2.29.3 (added) HH.mm esm/locale/id/_lib/formatLong/index.js package.json
date-fns@2.29.3 (added) HH.mm esm/locale/ms/_lib/formatLong/index.js package.json
date-fns@2.29.3 (added) HH.mm esm/locale/ms/_lib/formatLong/index.js package.json
date-fns@2.29.3 (added) HH.mm locale/fi/_lib/formatLong/index.js package.json
dayjs@1.11.7 (added) HH.mm esm/locale/fi.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm esm/locale/fi.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm esm/locale/fi.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm esm/locale/fi.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm esm/locale/fi.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm esm/locale/id.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm esm/locale/id.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm esm/locale/id.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm esm/locale/jv.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm esm/locale/jv.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm esm/locale/jv.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm esm/locale/ms-my.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm esm/locale/ms-my.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm esm/locale/ms-my.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm esm/locale/ms.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm esm/locale/ms.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm esm/locale/ms.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm esm/locale/sv-fi.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm esm/locale/sv-fi.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm esm/locale/sv-fi.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm esm/locale/sv-fi.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm esm/locale/sv-fi.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm esm/locale/tzl.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm esm/locale/tzl.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm esm/locale/tzl.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm locale/fi.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm locale/fi.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm locale/fi.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm locale/fi.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm locale/fi.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm locale/id.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm locale/id.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm locale/id.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm locale/jv.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm locale/jv.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm locale/jv.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm locale/ms-my.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm locale/ms-my.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm locale/ms-my.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm locale/ms.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm locale/ms.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm locale/ms.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm locale/sv-fi.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm locale/sv-fi.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm locale/sv-fi.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm locale/sv-fi.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm locale/sv-fi.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm locale/tzl.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm locale/tzl.js package.json via cypress@12.5.1
dayjs@1.11.7 (added) HH.mm locale/tzl.js package.json via cypress@12.5.1
moment@2.29.4 (added) HH.mm dist/locale/id.js package.json
moment@2.29.4 (added) HH.mm dist/locale/id.js package.json
moment@2.29.4 (added) HH.mm dist/locale/id.js package.json
moment@2.29.4 (added) HH.mm dist/locale/jv.js package.json
moment@2.29.4 (added) HH.mm dist/locale/jv.js package.json
moment@2.29.4 (added) HH.mm dist/locale/jv.js package.json
moment@2.29.4 (added) HH.mm dist/locale/ms-my.js package.json
moment@2.29.4 (added) HH.mm dist/locale/ms-my.js package.json
moment@2.29.4 (added) HH.mm dist/locale/ms-my.js package.json
moment@2.29.4 (added) HH.mm locale/fi.js package.json
moment@2.29.4 (added) HH.mm locale/fi.js package.json
moment@2.29.4 (added) HH.mm locale/fi.js package.json
moment@2.29.4 (added) HH.mm locale/fi.js package.json
moment@2.29.4 (added) HH.mm locale/fi.js package.json
moment@2.29.4 (added) HH.mm locale/id.js package.json
moment@2.29.4 (added) HH.mm locale/id.js package.json
moment@2.29.4 (added) HH.mm locale/id.js package.json
moment@2.29.4 (added) HH.mm locale/jv.js package.json
moment@2.29.4 (added) HH.mm locale/jv.js package.json
moment@2.29.4 (added) HH.mm locale/jv.js package.json
moment@2.29.4 (added) HH.mm locale/ms-my.js package.json
moment@2.29.4 (added) HH.mm locale/ms-my.js package.json
moment@2.29.4 (added) HH.mm locale/ms-my.js package.json
moment@2.29.4 (added) HH.mm locale/ms.js package.json
moment@2.29.4 (added) HH.mm locale/ms.js package.json
moment@2.29.4 (added) HH.mm locale/ms.js package.json
moment@2.29.4 (added) HH.mm locale/tzl.js package.json
moment@2.29.4 (added) HH.mm locale/tzl.js package.json
moment@2.29.4 (added) HH.mm locale/tzl.js package.json
moment@2.29.4 (added) HH.mm min/locales.min.js package.json
moment@2.29.4 (added) HH.mm min/locales.min.js package.json
moment@2.29.4 (added) HH.mm min/locales.min.js package.json
moment@2.29.4 (added) HH.mm min/locales.min.js package.json
moment@2.29.4 (added) HH.mm min/locales.min.js package.json
moment@2.29.4 (added) HH.mm min/locales.min.js package.json
moment@2.29.4 (added) HH.mm min/locales.min.js package.json
moment@2.29.4 (added) HH.mm min/locales.min.js package.json
moment@2.29.4 (added) HH.mm min/locales.min.js package.json
moment@2.29.4 (added) HH.mm min/locales.min.js package.json
moment@2.29.4 (added) HH.mm min/locales.min.js package.json
moment@2.29.4 (added) HH.mm min/locales.min.js package.json
moment@2.29.4 (added) HH.mm min/locales.min.js package.json
moment@2.29.4 (added) HH.mm min/locales.min.js package.json
moment@2.29.4 (added) HH.mm min/locales.min.js package.json
moment@2.29.4 (added) HH.mm min/locales.min.js package.json
moment@2.29.4 (added) HH.mm min/locales.min.js package.json
moment@2.29.4 (added) HH.mm min/locales.min.js package.json
moment@2.29.4 (added) HH.mm min/locales.min.js package.json
moment@2.29.4 (added) HH.mm min/locales.min.js package.json
moment@2.29.4 (added) HH.mm src/locale/id.js package.json
moment@2.29.4 (added) HH.mm src/locale/id.js package.json
moment@2.29.4 (added) HH.mm src/locale/id.js package.json
moment@2.29.4 (added) HH.mm src/locale/jv.js package.json
moment@2.29.4 (added) HH.mm src/locale/jv.js package.json
moment@2.29.4 (added) HH.mm src/locale/jv.js package.json
moment@2.29.4 (added) HH.mm src/locale/ms-my.js package.json
moment@2.29.4 (added) HH.mm src/locale/ms-my.js package.json
moment@2.29.4 (added) HH.mm src/locale/ms-my.js package.json
⚠️ No tests

Package does not have any tests. This is a strong signal of a poorly maintained or low quality package.

Add tests and publish a new version of the package. Consumers may look for an alternative package with better testing.

Package Location Source
css-background-parser@0.1.0 (added) package.json package.json via @vercel/og@0.1.0
detect-node@2.0.4 (added) package.json package.json via @types/react-query@1.2.9, mailing@0.9.10, mailing-core@0.9.10
detect-node-es@1.1.0 (added) package.json package.json via @radix-ui/react-popover@1.0.3
eslint-module-utils@2.7.4 (added) [package.json](https://socket.dev/npm/package/eslint-module-utils/files/

@dahal dahal merged commit 3d74147 into main Mar 2, 2023
@dahal dahal deleted the feat/more-to-members-page branch March 2, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dahal dahal

Labels
🚀 feature New feature or request
Projects
Roadmap
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dahal