Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: confirmation input and generic form #259

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

chetannn
Copy link
Collaborator

Description

I made the changes to the confirmation modal component. Still it's API is not stable but fine for now.
Also added a generic form component

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I documented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@chetannn chetannn requested a review from dahal March 19, 2023 13:36
@dahal dahal merged commit ae51824 into main Mar 20, 2023
@dahal dahal deleted the fix/confirmation-input-and-generic-form branch March 20, 2023 01:30
This was referenced Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants