Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: access action types for audit log #288

Merged
merged 2 commits into from
Mar 24, 2023
Merged

refactor: access action types for audit log #288

merged 2 commits into from
Mar 24, 2023

Conversation

chetannn
Copy link
Collaborator

@chetannn chetannn commented Mar 24, 2023 •
edited

Description

Added typescript constants to store all the access types.

Closes #159

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I documented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@chetannn chetannn requested a review from dahal March 24, 2023 01:57
@dahal dahal merged commit 050f02c into main Mar 24, 2023
@dahal dahal deleted the refactor/access-action-types branch March 24, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dahal dahal dahal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store all the project related types inside types folder
2 participants
@chetannn @dahal