Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: populate branches on new branch modal #368

Merged

Conversation

swapnil-talpade
Copy link
Contributor

@swapnil-talpade swapnil-talpade commented Apr 12, 2023

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #367

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • OS with version:
  • Browser with version:
  • SDK / CLI with version:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I documented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshot 2023-04-12 at 9 52 58 AM

Screenshot 2023-04-12 at 9 53 19 AM

Co-authored-by: Swapnil <55242050+swapnil-talpade@users.noreply.github.com>
@dahal
Copy link
Member

dahal commented Apr 12, 2023

Thanks for a quick turnaround @swapnil-talpade . I will go ahead and merge this. After seeing multiple use cases and multiple TRPC queries (on same page to fetch branches), it would be nice to create a zustand store to keep track of branches. Please take a look at #363 if you are up for this challenge.

@dahal dahal merged commit 2179fe8 into envless:main Apr 12, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Populate list of branches on create new branch modal.
2 participants