Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow linking individual rows #2

Closed
wants to merge 2 commits into from
Closed

Allow linking individual rows #2

wants to merge 2 commits into from

Conversation

fuddl
Copy link

@fuddl fuddl commented Dec 14, 2021

during the last challenge it was particularly hard to navigate the translations because there are so many languages that had the word Beard.

So the idea behind the change is that you can click the language in the Most improved languages table which then will navigate you to the language in the main table:

arrow pointing from Most improved languages to main table

  • I also added a background colour for the table row in question and
  • smooth scrolling to make the transition clear

This also enables users to link to a particular language of each challenge:
https://dicare.toolforge.org/lexemes/challenge.php#Q188

@envlh
Copy link
Owner

envlh commented Dec 21, 2021

Thank you!

I made some changes:

  • distinct link (so links with the languages labels still go to Wikidata)
  • distinct background color for the targeted row
  • no scroll-behavior, so without needing to wait

Please let me know what name you want me to add in the CONTRIBUTORS file.

@fuddl
Copy link
Author

fuddl commented Dec 21, 2021

Not Necessary

@fuddl fuddl closed this Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants