Skip to content

Commit

Permalink
Merge pull request #11 from envor/main
Browse files Browse the repository at this point in the history
callable args in return is not required
  • Loading branch information
inmanturbo committed Mar 6, 2024
2 parents 1e72c51 + 9586b8d commit 1537cfb
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/phpstan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
coverage: none

- name: Install composer dependencies
uses: ramsey/composer-install@v2
uses: ramsey/composer-install@v3

- name: Run PHPStan
run: ./vendor/bin/phpstan --error-format=github
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@

All notable changes to `laravel-datastore` will be documented in this file.

## v1.2.6 - 2024-02-22

### What's Changed

* bug fix by @inmanturbo in https://github.com/envor/laravel-datastore/pull/9

**Full Changelog**: https://github.com/envor/laravel-datastore/compare/v1.2.5...v1.2.6

## v1.2.5 - 2024-02-22

### What's Changed
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ Route::get('/contexed', fn() => 'OK')->middleware(\Envor\Datastore\DatastoreCont

```

Your user must implement the `HasDatastoreContext interface in order for this to work.
Your user must implement the `HasDatastoreContext` interface in order for this to work.

```php
...
Expand Down
2 changes: 1 addition & 1 deletion src/Datastore.php
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ public function run(?callable $callback): mixed
return $this;
}

public function return(?callable $callback): mixed
public function return(?callable $callback = null): mixed
{
return isset($callback) ? $callback($this->result) : $this->result;
}
Expand Down

0 comments on commit 1537cfb

Please sign in to comment.