Changed phone number normalization to use more robust method. #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're now using this method: https://www.npmjs.com/package/libphonenumber-js#parsephonenumberfromstringstring-defaultcountry
It also checks if the phone number is possible, which will not allow numbers that are too long or too short.
One thing to note, is that for requests that don't have a location associated with it, non-internationally formatted numbers will fail. For example, 516-555-5766 is a valid US number, but it's impossible for the library to format this into the international format that Twilio expects ( which prefixes +{country code} to the number), since it could also be a valid number in another country. Therefore having a location is imperative for best results.
I also temporarily fixed the failing tests that depended on request handlers being promise-based.