idle timeout test failure from upstream change #2108
Comments
alyssawilk
pushed a commit
that referenced
this issue
Nov 3, 2022
Description: Remove the use of removed override_request_timeout_by_gateway_timeout upstream Envoy flag from Swift tests. The flag was removed from the main config.cc as part of #2296 file months ago. The original removal introduced a bug as filter's onError callback started being called twice - this PR fixes this issue. Update EM code to correctly handle stream idle. See #2639 for more details. Fixes #2108. Risk Level: Medium, touches stream onDestroy code. Testing: Unit/Integration tests. Docs Changes: N/A Release Notes: N/A Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Brining envoyproxy/envoy@d7edf3b in results in some issues (see #2105)
To unblock upgrading we're disabling this change via runtime, but we'll need to figure out the cause of the disruption sometime before the runtime guard is removed
The text was updated successfully, but these errors were encountered: