Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging sink for Android #34

Closed
junr03 opened this issue Jun 4, 2019 · 3 comments · Fixed by #684
Closed

logging sink for Android #34

junr03 opened this issue Jun 4, 2019 · 3 comments · Fixed by #684
Labels
no stalebot platform/android Issues related to Android
Milestone
v0.3 "Secondi"

Comments

@junr03
Copy link
Member

junr03 commented Jun 4, 2019

Currently Envoy has a file logging sink, and a stderr logging sink. Both of these do not work with android. We need to implement an Android logging sink in order to get Envoy logs in Android. We can lift up spdlog's android_sink.
@junr03 junr03 added the platform/android Issues related to Android label Jun 4, 2019
@junr03 junr03 added this to the v0.2 "Primo" milestone Jun 4, 2019
@junr03 junr03 mentioned this issue Jun 17, 2019
Closed
@stale
Copy link

stale bot commented Jul 4, 2019

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 4, 2019
@junr03
Copy link
Member Author

junr03 commented Jan 22, 2020

Open PR in Envoy envoyproxy/envoy#9767

cc @buildbreaker @goaway

@junr03
Copy link
Member Author

junr03 commented Feb 10, 2020

Brought into envoy mobile by #663

@junr03 junr03 mentioned this issue Feb 11, 2020
Merged
junr03 added a commit that referenced this issue Feb 13, 2020
@junr03
android: update bazel flag config (#684)
98ea37c 
Description: envoyproxy/envoy#9767 introduced the bazel option and #663 brought it into envoy mobile. This PR changes the bazel config for android to turn on the logger by default when building on android. It also updates a couple other stale flags and docs.
Risk Level: low
Testing: tested locally and saw logs

Fixes #34

Signed-off-by: Jose Nino <jnino@lyft.com>
@Augustyniak Augustyniak mentioned this issue Nov 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
no stalebot platform/android Issues related to Android
Projects
None yet
Milestone
v0.3 "Secondi"
Development

Successfully merging a pull request may close this issue.

android: update bazel flag config envoyproxy/envoy-mobile
3 participants
@cafedomingo @rebello95 @junr03