Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous writes make onResponseHeaders to never happen #2212

Closed
wants to merge 1 commit into from

Conversation

carloseltuerto
Copy link
Contributor

@carloseltuerto carloseltuerto commented Apr 26, 2022

For testing - do not submit.

bazel test --config=clang  --define=signal_trace=disabled --spawn_strategy=standalone  test/java/org/chromium/net/testing:temporary_test

Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Signed-off-by: Charles Le Borgne cleborgne@google.com

…ever

happen

Signed-off-by: Charles Le Borgne <cleborgne@google.com>
@carloseltuerto carloseltuerto changed the title Continuous write makes onResponseHeaders to never happen Continuous writes make onResponseHeaders to never happen Apr 26, 2022
RyanTheOptimist added a commit to RyanTheOptimist/envoy-mobile that referenced this pull request Apr 27, 2022
but scheduling repeated onSendWindowAvailable calls in the next
dispatcher iteration.

Adds the regression test Charles cooked up in envoyproxy#2212

Fixes envoyproxy#2213
RyanTheOptimist added a commit to RyanTheOptimist/envoy-mobile that referenced this pull request Apr 27, 2022
by scheduling repeated onSendWindowAvailable calls in the next
dispatcher iteration.

Adds the regression test Charles cooked up in envoyproxy#2212

Fixes envoyproxy#2213

Signed-off-by: Ryan Hamilton <rch@google.com>
@carloseltuerto carloseltuerto deleted the cronvoy071 branch May 10, 2022 17:49
goaway pushed a commit that referenced this pull request May 10, 2022
…g, (#2221)

Description: Fix Envoy Mobile bug where writing prevents the read loop from running,
by scheduling repeated onSendWindowAvailable calls in the next
dispatcher iteration.

Adds the regression test Charles cooked up in #2212

Fixes #2213 

Risk Level: Low
Testing: New regression test
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Ryan Hamilton <rch@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant