-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
envoy: update to d0befbb
& add h2ExtendKeepaliveTimeout
#2229
Conversation
Signed-off-by: JP Simard <jp@jpsim.com>
We'll update this to drain the main host in an upcoming PR, but this keeps the existing behavior. Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Converting back to draft as I add an engine builder configuration for envoyproxy/envoy#21077. |
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
d0befbb
d0befbb
& add h2ExtendKeepaliveTimeout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! The flag is going to help us to measure the impact of a change. Hopefully it's going to improve things and we will be able to eventually remove h2ExtendKeepaliveTimeout
method from the public API (and just have the functionality enabled by default)
Signed-off-by: JP Simard <jp@jpsim.com>
* | ||
* @return This builder. | ||
*/ | ||
fun h2ExtendKeepaliveTimeout(h2ExtendKeepaliveTimeout: Boolean): EngineBuilder { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, one thing that I noticed is that other methods related to h2 ping are named using h2CONNECTIONKeepalive
prefix- if you want to add it that's great, if not I think that it's not a big deal as we are going to remove this method at some point anyway (most probably)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is already pretty verbose that I'd rather not make it even longer.
* origin/main: Bump rules_apple to 0.34.2 (#2236) Bump Lyft Support Rotation (#2232) ci: add support for `/retest` command (#2219) format: add SwiftLint to check-format script (#2230) use 64 bit emulators for test (#2228) envoy: update to `d0befbb` & add `h2ExtendKeepaliveTimeout` (#2229) Add Ryan Hamilton to OWNERS.md (#2224) Android cert verifier: first import from chromium/net (#2222) Signed-off-by: JP Simard <jp@jpsim.com>
…rtion * origin/main: (57 commits) network: add enableDrainPostDnsRefresh to iOS (#2242) envoy: update to em-cherry (#2241) network: support draining connections after triggered DNS refresh (#2225) Bump rules_apple to 0.34.2 (#2236) Bump Lyft Support Rotation (#2232) ci: add support for `/retest` command (#2219) format: add SwiftLint to check-format script (#2230) use 64 bit emulators for test (#2228) envoy: update to `d0befbb` & add `h2ExtendKeepaliveTimeout` (#2229) Add Ryan Hamilton to OWNERS.md (#2224) Android cert verifier: first import from chromium/net (#2222) Cleanup: remove the unused stats sink metrics_service (#2220) bazel: move back to symbol mapping table files (#2218) Add new version history section (#2209) build: simplify jnilib copy (#2214) ci: Update macOS version to macOS 12 (#2208) Update releasing.rst (#2200) support: Post Lyft support rotation changes to Slack (#2207) Don't run bump_support_rotation GitHub Action on forks (#2204) Release 0.4.6 (#2201) ... Signed-off-by: JP Simard <jp@jpsim.com>
Diff: envoyproxy/envoy@03f2376...d0befbb
To Do:
h2ExtendKeepaliveTimeout
option to engine buildersh2ExtendKeepaliveTimeout
properly sets thehttp2_delay_keepalive_timeout
reloadable feature in the yaml configuration