snag final stream info before destruction #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the Python 3.10 update broke the docs generation. I'll push a fix shortly. |
|
oh thanks, I was wondering what was going on there :-P |
|
Docs fixed in #2286 |
|
Change looks good to me, but I'd like @goaway to review as well. Could you please include a changelog entry in version_history.rst? |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
goaway
previously approved these changes
May 19, 2022
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
RyanTheOptimist
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, final stream intel was only retrieved if the stream was locally complete. now it should be consistently latched.
Testing: new integration test
Docs Changes:
Release Notes:
Fixes #2192