Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: add forceIPv6(...) builder option #2396

Merged
merged 1 commit into from
Jun 28, 2022
Merged

iOS: add forceIPv6(...) builder option #2396

merged 1 commit into from
Jun 28, 2022

Conversation

jpsim
Copy link
Contributor

@jpsim jpsim commented Jun 28, 2022

Mirroring what was done for Android in #2379 and leveraging the recent changes in Envoy in envoyproxy/envoy#21913.

Risk Level: Moderate.
Testing: Unit tests, integration tests & being exercised in the experimental app. Tested with the experimental app in the iOS Simulator and on an iPhone 13 Pro, verified that an IPv4 address gets mapped to a valid IPv6 address.
Docs Changes: Added.
Release Notes: Added.

Signed-off-by: JP Simard jp@jpsim.com

Signed-off-by: JP Simard <jp@jpsim.com>
@jpsim jpsim requested review from goaway and Augustyniak June 28, 2022 19:38
Copy link
Contributor

@Augustyniak Augustyniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream Envoy changes look 'fine' (or at least there are not a lot of them(

@jpsim jpsim marked this pull request as ready for review June 28, 2022 19:57
@jpsim jpsim enabled auto-merge (squash) June 28, 2022 20:42
@jpsim jpsim merged commit 09272d6 into main Jun 28, 2022
@jpsim jpsim deleted the ios-force-ipv6 branch June 28, 2022 20:43
jpsim added a commit that referenced this pull request Jul 5, 2022
* origin/main:
  Update Envoy (#2403)
  connectivity_manager: rename/refactor from Network::Configurator (#2401)
  test: fixing up build targets to use the extension registry (#2397)
  test: Adds an integration test for SDS (#2395)
  iOS: add `forceIPv6(...)` builder option (#2396)
  api: make iOS Headers and HeadersBuilder case-insensitive (#2383)

Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants