iOS: add KeyValueStore protocol conformance to UserDefaults
#2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Schore <mike.schore@gmail.com>
In favor of adding `KeyValueStore` conformance to `UserDefaults` directly. Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
goaway
reviewed
Aug 3, 2022
| "filters/*.swift", | ||
| "grpc/*.swift", | ||
| "mocks/*.swift", | ||
| "stats/*.swift", |
There was a problem hiding this comment.
Personally, I'd prefer we explicitly enumerate source files in build targets and avoid blobs. I feel it obscures information about what's being pulled in, and it has the potential to lead to surprises when files are moved around.
Upstream Envoy tends to follow the pattern of explicit enumeration of source files as well, even when that list is large.
There was a problem hiding this comment.
Done. I don't feel strongly but the previous approach was inconsistent with a mix of explicit files and globs.
As of 4d77493 everything is being explicitly set.
As requested in code review. Signed-off-by: JP Simard <jp@jpsim.com>
|
/retest |
Augustyniak
approved these changes
Aug 3, 2022
RyanTheOptimist
pushed a commit
to RyanTheOptimist/envoy-mobile
that referenced
this pull request
Aug 3, 2022
…yproxy#2452) Continued from envoyproxy#2441. Description: Parallels Android implementation based on SharedPreferences. Risk Level: Low Testing: Application Co-authored-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from #2441.
Description: Parallels Android implementation based on SharedPreferences.
Risk Level: Low
Testing: Application
Co-authored-by: Mike Schore mike.schore@gmail.com
Signed-off-by: JP Simard jp@jpsim.com