android: enable forceIPv6 by default #2510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
|
/retest |
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
jpsim
reviewed
Sep 1, 2022
docs/root/intro/version_history.rst
Outdated
| @@ -47,6 +47,7 @@ Features: | |||
| - api: improved C++ APIs compatibility with Java / Kotlin / Swift (:issue `#2362 <2362>`) | |||
| - api: add option to use the a ``getaddrinfo``-based system DNS resolver instead of c-ares (:issue: `#2419 <2419>`) | |||
| - iOS: add ``KeyValueStore`` protocol conformance to ``UserDefaults`` (:issue: `#2452 <2452>`) | |||
| - android: enable forcing of IPv6 socket addresses by default and remove ``forceIPv6`` method from the engine builder. (:issue: `#2510 <2510>`) | |||
There was a problem hiding this comment.
I wonder if we should adjust this line to reflect this:
- api: add experimental option to force all connections to use IPv6 (:issue: `#2379 <2379>`, :issue: `#2396 <2396>`)
There was a problem hiding this comment.
yep, great point - done. I still use 'ios' / 'android' to stay consistent for this release but planning to move to swift etc in the next release.
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
jpsim
reviewed
Sep 1, 2022
| {"dns_preresolve_hostnames", this->dns_preresolve_hostnames_}, | ||
| {"dns_refresh_rate", fmt::format("{}s", this->dns_refresh_seconds_)}, | ||
| {"dns_query_timeout", fmt::format("{}s", this->dns_query_timeout_seconds_)}, | ||
| {"dns_resolver_name", dns_resolver_name}, {"dns_resolver_config", dns_resolver_config}, |
There was a problem hiding this comment.
Can we keep these on two lines?
Suggested change
| {"dns_resolver_name", dns_resolver_name}, {"dns_resolver_config", dns_resolver_config}, | |
| {"dns_resolver_name", dns_resolver_name}, | |
| {"dns_resolver_config", dns_resolver_config}, |
There was a problem hiding this comment.
it's a linter tool that made a change in here. It does not allow me to make a change from your suggestion.
For reference, I ran ./tools/code_format/check_format.py fix ../library/ from within envoy directory locally.
There was a problem hiding this comment.
huh, interesting that it was previously on two lines.
jpsim
approved these changes
Sep 1, 2022
jpsim
added a commit
that referenced
this pull request
Sep 1, 2022
…e-the-system-dns-resolver * origin/main: android: enable forceIPv6 by default (#2510) Signed-off-by: JP Simard <jp@jpsim.com>
colibie
pushed a commit
to colibie/envoy-mobile
that referenced
this pull request
Sep 21, 2022
Description: Forcing the use of IPv6 socket addresses is required to make Envoy Mobile work with some carriers when running on an Android device. The option was introduced upstream in envoyproxy/envoy#21803. Risk Level: Low, enabled a well tested option. Testing: Manual, launched the example app Docs Changes: Updated Release Notes: Updated Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com> Signed-off-by: Chidera Olibie <colibie@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Forcing the use of IPv6 socket addresses is required to make Envoy Mobile work with some carriers when running on an Android device. The option was introduced upstream in envoyproxy/envoy#21803.
Risk Level: Low, enabled a well tested option.
Testing: Manual, launched the example app
Docs Changes: Updated
Release Notes: Updated
Signed-off-by: Rafal Augustyniak raugustyniak@lyft.com