Skip to content

Commit

Permalink
TODO
Browse files Browse the repository at this point in the history
Signed-off-by: Ryan Hamilton <rch@google.com>
  • Loading branch information
RyanTheOptimist committed Mar 6, 2024
1 parent 773357a commit 4af7d6d
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions source/common/runtime/runtime_features.cc
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,6 @@ RUNTIME_GUARD(envoy_reloadable_features_http1_connection_close_header_in_redirec
RUNTIME_GUARD(envoy_reloadable_features_http1_use_balsa_parser);
RUNTIME_GUARD(envoy_reloadable_features_http2_decode_metadata_with_quiche);
RUNTIME_GUARD(envoy_reloadable_features_http2_discard_host_header);
// Ignore the automated "remove this flag" issue: we should keep this for 1 year.
FALSE_RUNTIME_GUARD(envoy_reloadable_features_http2_use_oghttp2);
RUNTIME_GUARD(envoy_reloadable_features_http2_validate_authority_with_quiche);
RUNTIME_GUARD(envoy_reloadable_features_http_allow_partial_urls_in_referer);
RUNTIME_GUARD(envoy_reloadable_features_http_filter_avoid_reentrant_local_reply);
Expand Down Expand Up @@ -110,6 +108,9 @@ RUNTIME_GUARD(envoy_restart_features_use_eds_cache_for_ads);

// Begin false flags. Most of them should come with a TODO to flip true.

// TODO(birenroy) Flip this to true after resolving issues.
// Ignore the automated "remove this flag" issue: we should keep this for 1 year.
FALSE_RUNTIME_GUARD(envoy_reloadable_features_http2_use_oghttp2);
// Execution context is optional and must be enabled explicitly.
// See https://github.com/envoyproxy/envoy/issues/32012.
FALSE_RUNTIME_GUARD(envoy_restart_features_enable_execution_context);
Expand Down

0 comments on commit 4af7d6d

Please sign in to comment.