Improve resource manager impl test (#109)

envoyproxy · Sep 30, 2016 · a6271f2 · a6271f2
1 parent 89de442
commit a6271f2
Showing 1 changed file with 18 additions and 9 deletions.
diff --git a/test/common/upstream/resource_manager_impl_test.cc b/test/common/upstream/resource_manager_impl_test.cc
@@ -10,28 +10,37 @@ namespace Upstream {
 TEST(ResourceManagerImplTest, RuntimeResourceManager) {
   NiceMock<Runtime::MockLoader> runtime;
   ResourceManagerImpl resource_manager(
-      runtime, "circuit_breakers.runtime_resource_manager_test.default.", 0, 0, 0, 0);
+      runtime, "circuit_breakers.runtime_resource_manager_test.default.", 0, 0, 0, 1);
 
-  EXPECT_CALL(runtime.snapshot_,
-              getInteger("circuit_breakers.runtime_resource_manager_test.default.max_connections",
-                         0U)).WillOnce(Return(1U));
+  EXPECT_CALL(
+      runtime.snapshot_,
+      getInteger("circuit_breakers.runtime_resource_manager_test.default.max_connections", 0U))
+      .Times(2)
+      .WillRepeatedly(Return(1U));
   EXPECT_EQ(1U, resource_manager.connections().max());
+  EXPECT_TRUE(resource_manager.connections().canCreate());
 
   EXPECT_CALL(
       runtime.snapshot_,
       getInteger("circuit_breakers.runtime_resource_manager_test.default.max_pending_requests", 0U))
-      .WillOnce(Return(2U));
+      .Times(2)
+      .WillRepeatedly(Return(2U));
   EXPECT_EQ(2U, resource_manager.pendingRequests().max());
+  EXPECT_TRUE(resource_manager.pendingRequests().canCreate());
 
   EXPECT_CALL(runtime.snapshot_,
               getInteger("circuit_breakers.runtime_resource_manager_test.default.max_requests", 0U))
-      .WillOnce(Return(3U));
+      .Times(2)
+      .WillRepeatedly(Return(3U));
   EXPECT_EQ(3U, resource_manager.requests().max());
+  EXPECT_TRUE(resource_manager.requests().canCreate());
 
   EXPECT_CALL(runtime.snapshot_,
-              getInteger("circuit_breakers.runtime_resource_manager_test.default.max_retries", 0U))
-      .WillOnce(Return(4U));
-  EXPECT_EQ(4U, resource_manager.retries().max());
+              getInteger("circuit_breakers.runtime_resource_manager_test.default.max_retries", 1U))
+      .Times(2)
+      .WillRepeatedly(Return(0U));
+  EXPECT_EQ(0U, resource_manager.retries().max());
+  EXPECT_FALSE(resource_manager.retries().canCreate());
 }
 
 } // Upstream