Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
Signed-off-by: Matt Klein <mklein@lyft.com>
  • Loading branch information
Matt Klein committed Dec 15, 2020
1 parent 8491785 commit a6d2b17
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions source/extensions/upstreams/http/tcp/upstream_request.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ namespace Tcp {
class TcpConnPool : public Router::GenericConnPool, public Envoy::Tcp::ConnectionPool::Callbacks {
public:
TcpConnPool(Upstream::ThreadLocalCluster& thread_local_cluster, bool is_connect,
const Router::RouteEntry& route_entry,
absl::optional<Envoy::Http::Protocol>, Upstream::LoadBalancerContext* ctx) {
const Router::RouteEntry& route_entry, absl::optional<Envoy::Http::Protocol>,
Upstream::LoadBalancerContext* ctx) {
ASSERT(is_connect);
conn_pool_ = thread_local_cluster.tcpConnPool(route_entry.priority(), ctx);
}
Expand Down
2 changes: 1 addition & 1 deletion test/extensions/upstreams/tcp/generic/config_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class TcpConnPoolTest : public ::testing::Test {
NiceMock<Envoy::Tcp::ConnectionPool::MockUpstreamCallbacks> callbacks_;
};

TEST_F(TcpConnPoolTest, TestNoHost) {
TEST_F(TcpConnPoolTest, TestNoConnPool) {
envoy::extensions::filters::network::tcp_proxy::v3::TcpProxy_TunnelingConfig config;
config.set_hostname("host");
EXPECT_CALL(thread_local_cluster_, httpConnPool(_, _, _)).WillOnce(Return(nullptr));
Expand Down

0 comments on commit a6d2b17

Please sign in to comment.