Skip to content

Commit

Permalink
bazel: fix more config_setting visibility (#23709)
Browse files Browse the repository at this point in the history
Fixes #23390

This is an edge case, upstream issue: bazelbuild/bazel-skylib#404

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
  • Loading branch information
keith committed Oct 28, 2022
1 parent ff63710 commit b3e59bd
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions bazel/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -304,15 +304,17 @@ config_setting(
bool_flag(
name = "http3",
build_setting_default = True,
visibility = ["//visibility:private"],
# TODO(keith): make private again https://github.com/bazelbuild/bazel-skylib/issues/404
# visibility = ["//visibility:private"],
)

config_setting(
name = "disable_http3_setting",
flag_values = {
":http3": "False",
},
visibility = ["//visibility:private"],
# TODO(keith): make private again https://github.com/bazelbuild/bazel-skylib/issues/404
# visibility = ["//visibility:private"],
)

selects.config_setting_group(
Expand All @@ -331,7 +333,8 @@ config_setting(
config_setting(
name = "disable_hot_restart_setting",
values = {"define": "hot_restart=disabled"},
visibility = ["//visibility:private"],
# TODO(keith): make private again https://github.com/bazelbuild/bazel-skylib/issues/404
# visibility = ["//visibility:private"],
)

selects.config_setting_group(
Expand Down

0 comments on commit b3e59bd

Please sign in to comment.