Skip to content

Commit

Permalink
Add clarifying comment about virtual domain name in proto files
Browse files Browse the repository at this point in the history
Signed-off-by: Anton Kaymakchi <tonysignal@gmail.com>
  • Loading branch information
StupidScience committed Jun 24, 2024
1 parent 69b1bc8 commit e3f648d
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion api/envoy/data/dns/v3/dns_table.proto
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,10 @@ message DnsTable {
option (udpa.annotations.versioning).previous_message_type =
"envoy.data.dns.v2alpha.DnsTable.DnsVirtualDomain";

// A domain name for which Envoy will respond to query requests
// A domain name for which Envoy will respond to query requests.
// Wildcard records are supported on the first label only, e.g. `*.example.com` or `*.subdomain.example.com`.
// Names such as `*example.com`, `subdomain.*.example.com`, `*subdomain.example.com`, etc
// are not valid wildcard names and asterisk will be interpreted as a literal `*` character.
string name = 1 [(validate.rules).string = {min_len: 1 well_known_regex: HTTP_HEADER_NAME}];

// The configuration containing the method to determine the address of this endpoint
Expand Down

0 comments on commit e3f648d

Please sign in to comment.