Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed_duration_ms is not working in Fault Injection. #11095

Closed
mk46 opened this issue May 7, 2020 · 13 comments · Fixed by #11715
Closed

fixed_duration_ms is not working in Fault Injection. #11095

mk46 opened this issue May 7, 2020 · 13 comments · Fixed by #11715
Assignees
@cpakulski
Labels
bug help wanted Needs help! question Questions that are neither investigations, bugs, nor enhancements

Comments

@mk46
Copy link
Contributor

mk46 commented May 7, 2020

I follow https://www.envoyproxy.io/docs/envoy/latest/start/sandboxes/fault_injection
and run bash enable_delay_fault_injection.sh
Observing response from backend service but not getting any delay.
@alyssawilk alyssawilk added the question Questions that are neither investigations, bugs, nor enhancements label May 7, 2020
@stale
Copy link

stale bot commented Jun 6, 2020

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Jun 6, 2020
@stale
Copy link

stale bot commented Jun 13, 2020

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions.

@stale stale bot closed this as completed Jun 13, 2020
@mk46
Copy link
Contributor Author

mk46 commented Jun 19, 2020

Hi @alyssawilk, Can we reopen this issue. I try with v1.9.0- v.1.10.0 but facing the same problem?

@moderation
Copy link
Contributor

@mk46 1.9.0 and 1.10.0 are very old by Envoy standards. You should test with 1.14.2 - https://www.envoyproxy.io/docs/envoy/v1.14.2/intro/version_history

@mk46
Copy link
Contributor Author

mk46 commented Jun 20, 2020

@moderation I have done this for 1.14.2, facing the same issue. Not sure but the delay of 3s

envoy/examples/fault-injection/enable_delay_fault_injection.sh

Line 6 in 7f251da

echo '3000' > /srv/runtime/v1/envoy/fault/http/delay/fixed_duration_ms

doesn't affect response time.

@alyssawilk
Copy link
Contributor

Looking at the docs, it looks like you should only see a delay on half the requests. Are you not seeing it on any? It'd help if you could attach some logs of what you're seeing. Thanks!

@mk46
Copy link
Contributor Author

mk46 commented Jun 22, 2020

@alyssawilk I have not seen any delay except delay of 1s between two requests

envoy/examples/fault-injection/send_request.sh

Line 6 in 3efafaa

sleep 1
and attached the log below.

@alyssawilk alyssawilk added bug help wanted Needs help! and removed stale stalebot believes this issue/PR has not been touched recently labels Jun 22, 2020
@alyssawilk
Copy link
Contributor

I meant the Envoy logs, sorry for not being clear.
Anyway, played around with it myself and it does look like something isn't up to date. I'll go ahead and reopen

@alyssawilk alyssawilk reopened this Jun 22, 2020
@cpakulski
Copy link
Contributor

I am looking at this issue.

@mk46
Copy link
Contributor Author

mk46 commented Jun 23, 2020

I have attached the envoy log. Response getting after applying delay is from
https://github.com/mk46/test/blob/b0e918666a6961ae01d73b2e48be4cff7c2be811/envoy.log#L122

@alyssawilk
Copy link
Contributor

Awesome, thanks @cpakulski

@cpakulski cpakulski mentioned this issue Jun 23, 2020
Merged
@cpakulski
Copy link
Contributor

@mk46 Please check changes in PR #11715. If you do not want to wait until it is merged into master update your local envoy.yaml file, rebuild images and it should be fine now.

@mk46
Copy link
Contributor Author

mk46 commented Jun 24, 2020

@cpakulski It's working now. Thanks!

alyssawilk pushed a commit that referenced this issue Jun 25, 2020
@cpakulski
examples: fixed fault-injection delay demo (#11715)
d0b4b4f 
fault injection example did not work for delay option. After gdb debugging it was discovered that fault injection config requires delay part to be present. Without delay part Envoy assumes that Delay is disabled and does not scan RTDS for delay config updates.

Risk Level: Low:
Testing: Did manual testing as described in https://www.envoyproxy.io/docs/envoy/latest/start/sandboxes/fault_injection
Docs Changes: No
Release Notes: No
Fixes: #11095
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
chaoqin-li1123 pushed a commit to chaoqin-li1123/envoy that referenced this issue Jun 25, 2020
@cpakulski
examples: fixed fault-injection delay demo (envoyproxy#11715)
2c9a3b8 
fault injection example did not work for delay option. After gdb debugging it was discovered that fault injection config requires delay part to be present. Without delay part Envoy assumes that Delay is disabled and does not scan RTDS for delay config updates.

Risk Level: Low:
Testing: Did manual testing as described in https://www.envoyproxy.io/docs/envoy/latest/start/sandboxes/fault_injection
Docs Changes: No
Release Notes: No
Fixes: envoyproxy#11095
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: chaoqinli <chaoqinli@google.com>
songhu pushed a commit to songhu/envoy that referenced this issue Jun 25, 2020
@cpakulski @songhu
examples: fixed fault-injection delay demo (envoyproxy#11715)
aec0c96 
fault injection example did not work for delay option. After gdb debugging it was discovered that fault injection config requires delay part to be present. Without delay part Envoy assumes that Delay is disabled and does not scan RTDS for delay config updates.

Risk Level: Low:
Testing: Did manual testing as described in https://www.envoyproxy.io/docs/envoy/latest/start/sandboxes/fault_injection
Docs Changes: No
Release Notes: No
Fixes: envoyproxy#11095
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
yashwant121 pushed a commit to yashwant121/envoy that referenced this issue Jul 24, 2020
@cpakulski @yashwant121
examples: fixed fault-injection delay demo (envoyproxy#11715)
f81ceeb 
fault injection example did not work for delay option. After gdb debugging it was discovered that fault injection config requires delay part to be present. Without delay part Envoy assumes that Delay is disabled and does not scan RTDS for delay config updates.

Risk Level: Low:
Testing: Did manual testing as described in https://www.envoyproxy.io/docs/envoy/latest/start/sandboxes/fault_injection
Docs Changes: No
Release Notes: No
Fixes: envoyproxy#11095
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpakulski cpakulski

Labels
bug help wanted Needs help! question Questions that are neither investigations, bugs, nor enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

examples: fixed fault-injection delay demo cpakulski/envoy
4 participants
@moderation @alyssawilk @cpakulski @mk46