Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with SkyWalking distributed tracing framework #12486

Closed
zyfjeff opened this issue Aug 5, 2020 · 10 comments
Closed

Integrate with SkyWalking distributed tracing framework #12486

zyfjeff opened this issue Aug 5, 2020 · 10 comments
Assignees
Labels
area/tracing enhancement Feature requests. Not bugs or questions. no stalebot Disables stalebot from closing an issue

Comments

@zyfjeff
Copy link
Member

zyfjeff commented Aug 5, 2020

I am from Alibaba Cloud team. We provide cloud service for hosted Istio/Envoy as a mesh solution.
Some of our users are using Apache SkyWalking language agents in their services, now, they want to migrate to the Istio mesh solution.Apache SkyWalking has provided fully topology, metrics, and alarms solution in the service mesh scenario,
but we still want the Envoy could support tracing by following the SkyWalking data model, which is different from the Zipkin model.

The Context Propagation should follow this, Standard Header Item is enough for step one.
https://github.com/apache/skywalking/blob/master/docs/en/protocols/Skywalking-Cross-Process-Propagation-Headers-Protocol-v3.md

The spans should follow this,
https://github.com/apache/skywalking-data-collect-protocol/blob/master/language-agent/Tracing.proto#L28-L31

@lizan

@dio dio added enhancement Feature requests. Not bugs or questions. area/tracing labels Aug 5, 2020
@lizan
Copy link
Member

lizan commented Aug 5, 2020

Thanks for raising this, we do also have similar use case. I'm happy to sponsor.

@wbpcode
Copy link
Member

wbpcode commented Aug 27, 2020

is any process for this work? @lizan We are about to do the same. But I don't know what the community's plans are.

@dio
Copy link
Member

dio commented Aug 27, 2020

@wbpcode if you’re interested I think you can take this. I can help you on the review.

@dio
Copy link
Member

dio commented Aug 27, 2020

@wbpcode I actually have an initial code for this. If you think it will be helpful for you to get started, I can share it with you.

@wbpcode
Copy link
Member

wbpcode commented Aug 27, 2020

@dio Thank you very much. I can try it out. Because we desperately need this feature and are willing to share the end result.
Where can I see your initial version? It would be very helpful.

@dio
Copy link
Member

dio commented Aug 27, 2020

Here you are: https://github.com/envoyproxy/envoy/compare/master...dio:sky-tracer?expand=1. I think it compiles and I had a docker-compose setup to "manually" test it (two services, with envoys, oap-server, and UI), I'll clean up the test bed and share it with you.

@XuejiaoZhang
Copy link

It will be great to have Skywalking integration with Envoy.

@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Oct 4, 2020
@dio dio added no stalebot Disables stalebot from closing an issue and removed stale stalebot believes this issue/PR has not been touched recently labels Oct 5, 2020
@wbpcode
Copy link
Member

wbpcode commented Dec 12, 2020

It's over. May be we can close it. @zyfjeff

@zyfjeff
Copy link
Member Author

zyfjeff commented Dec 12, 2020

@wbpcode Great work, I'll close it

@zyfjeff zyfjeff closed this as completed Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tracing enhancement Feature requests. Not bugs or questions. no stalebot Disables stalebot from closing an issue
Projects
None yet
Development

No branches or pull requests

5 participants