-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify the Observe service mesh through ALS
steps in README
#5394
Comments
You are mixing two things together. For application.yml, this is the standard and official way when you deploy SkyWalking from the tarball. |
Helm is just a quick way, it just covers 70%~ features which you could do through the real application.yml. That is also the same we(Apache) only call the source release is the official release. The binary and docker image are never the release. |
Thanks for answering. I totally understand the Helm config just exposes part of parameters of
|
I mean, helm should have done these two steps. |
Probably it's not the case, or I may miss something.
But didn't see the settings of
Do you have any clue about this? Thanks. |
Didn't helm set |
@XuejiaoZhang If you are using docker compose only, you need to set the system env value by yourself. |
@wu-sheng I run docker locally just to check whether helm meets the requirements of integration with Istio or not. |
Send your pull request if this is missed. We could talk more there. |
Sure, thanks a lot. |
@wu-sheng @XuejiaoZhang ALS relevant parameters are not in the core. In order to support them, helm chart has introduced https://github.com/apache/skywalking-kubernetes/blob/d383403a58fefa901b03bcdb925db402a17e8718/chart/skywalking/values.yaml#L61 to set them up. |
@innerpeacez From my understanding,
This has been included, right? |
|
Then, I think It used to be like this, https://github.com/apache/skywalking/blob/v6.6.0/docker/oap/docker-entrypoint.sh#L380-L382, but with the 8.x enhancement, it is simply like this, https://github.com/apache/skywalking/blob/v8.1.0/docker/oap/docker-entrypoint.sh |
Ok i will remove it. @wu-sheng |
Could anyone update either skywalking or skywalking-kubernetes document to include the steps of integrate Skywalking with Istio through ALS via the helm install way? |
Corrently, only set |
This error shows, you can't read the pod inform from the API server. cc @hanahmily |
@hanahmily Thanks. I followed the instructions. The "APM" Dashboard of SkyWalking was showed correctly, but nothing on the Tracing page, while the tracing data could be seen on.Jaeger. With the current method, nothing is needed to be done on the application code side, right? |
I think that is another thing. Tracing must have something related to the codes, even Javaagent(auto-instrumentation) is doing the thing in the runtime only. ALS solution is not for tracing, tracing is for the language agent case. You could install agent/SDK in your application, and close the |
Oh, I was expecting |
Technically impossible, sorry :)
Envoy tracing is tracing the things inside the envoy. It doesn't replace the code instrumentation. Then envoy tracing progress is lead by Envoy core maintainers, envoyproxy/envoy#12486. You could show you interests there, which should accelerate the progress |
Yup, thanks, will followup there. |
Please answer these questions before submitting your issue.
Requirement or improvement
Clarify the
Observe service mesh through ALS
steps in READMEThe current description is confusing, would you please clarify the steps.
It mentionns
a) please clarify how to
open
envoy receiver, I sawenvoy-metric
section is already inapplication.yaml
b) please clarify how to
Active ALS k8s-mesh analysis
, where should the following be put?c) from skywalking helm, I saw configuration named
oap.envoy.als.enabled
, is this required to set totrue
in values.yamlThanks in advance. This will definitely help a lot to integrate Skywalking with Istio.
The text was updated successfully, but these errors were encountered: