Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further work on x-envoy-immediate-health-check-fail #1572

Closed
3 tasks
mattklein123 opened this issue Aug 30, 2017 · 2 comments
Closed
3 tasks

Further work on x-envoy-immediate-health-check-fail #1572

mattklein123 opened this issue Aug 30, 2017 · 2 comments
Labels
enhancement Feature requests. Not bugs or questions. help wanted Needs help!

Comments

@mattklein123
Copy link
Member

mattklein123 commented Aug 30, 2017 •
edited
Loading

Related to #1423 and #1570.

We should consider further enhancements to this feature:

  • When using /healthcheck/fail admin endpoint, have some period of drain time before starting 100% drain/close.
  • Add ability for header value to specify things like TTL for failure if used for load shedding. (Need to think about whether this counts as an outlier ejection vs. active health check).
  • Potentially ASSERT more thread locality stuff.

cc @alyssawilk
@mattklein123 mattklein123 added the enhancement Feature requests. Not bugs or questions. label Aug 30, 2017
@mattklein123 mattklein123 mentioned this issue Aug 30, 2017
Merged
@mattklein123 mattklein123 modified the milestone: 1.5.0 Aug 30, 2017
@mattklein123 mattklein123 self-assigned this Sep 11, 2017
@mattklein123 mattklein123 modified the milestones: 1.5.0, 1.6.0 Nov 3, 2017
@mattklein123 mattklein123 mentioned this issue Jan 3, 2018
Closed
@mattklein123 mattklein123 removed this from the 1.6.0 milestone Jan 9, 2018
@mattklein123 mattklein123 removed their assignment Jan 10, 2018
@stale
Copy link

stale bot commented Jun 20, 2018

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Jun 20, 2018
@mattklein123 mattklein123 added the help wanted Needs help! label Jun 20, 2018
@stale stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Jun 20, 2018
@mattklein123
Copy link
Member Author

Closing this out as this has not been an issue in practice. Can reopen more specific actions if needed.

jpsim pushed a commit that referenced this issue Nov 28, 2022
@alyssawilk @jpsim
android: attempting to respect Android's cleartext policies (#2318)
ec3b0cc 
Rejecting requests which don't have an https scheme if Android disallows cleartext

Risk Level: High
Testing: TODO (envoyproxy/envoy-mobile#2341)
Docs Changes: n/a
Release Notes: inline
Fixes #1572

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this issue Nov 29, 2022
@alyssawilk @jpsim
android: attempting to respect Android's cleartext policies (#2318)
18ad777 
Rejecting requests which don't have an https scheme if Android disallows cleartext

Risk Level: High
Testing: TODO (envoyproxy/envoy-mobile#2341)
Docs Changes: n/a
Release Notes: inline
Fixes #1572

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature requests. Not bugs or questions. help wanted Needs help!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mattklein123