Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configurable error code when route points to unkown/invalid cluster #1820

Closed
ldemailly opened this issue Oct 5, 2017 · 0 comments
Closed

configurable error code when route points to unkown/invalid cluster #1820

ldemailly opened this issue Oct 5, 2017 · 0 comments
Assignees
@PiotrSikora
Labels
beginner Good starter issues! enhancement Feature requests. Not bugs or questions.
Milestone
1.6.0

Comments

@ldemailly
Copy link

Right now it returns a 404

The argument can be made for a 503 as 404 could cause the caller to consider the entry permanently deleted (cc @costinm to fill that part in - but basically imagine /calendar/meeting123 getting polled for refresh and suddenly getting a (transient) 404 during rule change, it thens disappear from the users calendar)

If it's configurable everyone is happy :-)
@mattklein123 mattklein123 added enhancement Feature requests. Not bugs or questions. help wanted Needs help! labels Oct 5, 2017
@ldemailly ldemailly mentioned this issue Oct 5, 2017
Closed
@mattklein123 mattklein123 added the beginner Good starter issues! label Oct 28, 2017
@mattklein123 mattklein123 mentioned this issue Oct 30, 2017
Closed
PiotrSikora added a commit to PiotrSikora/envoy that referenced this issue Oct 30, 2017
@PiotrSikora
router: return 503 when cluster isn't found.
c62e4a6 
Fixes envoyproxy#1820.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora PiotrSikora mentioned this issue Oct 30, 2017
Merged
@kyessenov kyessenov mentioned this issue Nov 3, 2017
Closed
@PiotrSikora PiotrSikora mentioned this issue Nov 16, 2017
Merged
@mattklein123 mattklein123 added this to the 1.6.0 milestone Nov 26, 2017
@mattklein123 mattklein123 removed the help wanted Needs help! label Nov 26, 2017
mattklein123 pushed a commit that referenced this issue Dec 2, 2017
@PiotrSikora
router: return 503 when cluster isn't found. (#1971)
fcdeef9 
Fixes #1820.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
rshriram pushed a commit to rshriram/envoy that referenced this issue Oct 30, 2018
@PiotrSikora @istio-testing
Fix license headers and check for them in CircleCI. (envoyproxy#1820)
4b65248 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
jpsim pushed a commit that referenced this issue Nov 28, 2022
@keith @jpsim
bazel: remove unnecessary rules_foreign_cc load (#1820)
1e5f804 
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this issue Nov 29, 2022
@keith @jpsim
bazel: remove unnecessary rules_foreign_cc load (#1820)
73d160c 
Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PiotrSikora PiotrSikora

Labels
beginner Good starter issues! enhancement Feature requests. Not bugs or questions.
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
3 participants
@PiotrSikora @ldemailly @mattklein123