Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIQ Load Balancing #2044

Open
toaler opened this issue Nov 10, 2017 · 2 comments
Open

JIQ Load Balancing #2044

toaler opened this issue Nov 10, 2017 · 2 comments
Labels
enhancement Feature requests. Not bugs or questions. help wanted Needs help!

Comments

@toaler
Copy link

toaler commented Nov 10, 2017

It looks like Envoy currently implements Power-of-two load balancing (Weighted Least Request). Is there any plans to implement JIQ load balancing?

Based on the research [1] JIQ has advantages of Power-of-two. Has this been something considered to date? If a contributor is looking at add yet-another-LB-algorithm, what part of the code base should they start to look at?

[1] https://www.microsoft.com/en-us/research/wp-content/uploads/2011/10/idleq.pdf

@mattklein123 mattklein123 added enhancement Feature requests. Not bugs or questions. help wanted Needs help! labels Nov 10, 2017
@mattklein123
Copy link
Member

I haven't seen that one yet. Will read the paper.

Adding a new LB is pretty easy. See here for examples:
https://github.com/envoyproxy/envoy/blob/master/source/common/upstream/load_balancer_impl.h
https://github.com/envoyproxy/envoy/blob/master/source/common/upstream/ring_hash_lb.h

@toaler
Copy link
Author

toaler commented Nov 10, 2017

Cheers @mattklein123 will look at the code.

Shikugawa pushed a commit to Shikugawa/envoy that referenced this issue Mar 28, 2020
Signed-off-by: Wayne Zhang <qiwzhang@google.com>
jpsim pushed a commit that referenced this issue Nov 28, 2022
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this issue Nov 29, 2022
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests. Not bugs or questions. help wanted Needs help!
Projects
None yet
Development

No branches or pull requests

2 participants