Please regenerate RBE toolchain configs

[Wyverald]

Problem: Envoy RBE is failing on Bazel@HEAD+Downstream pipeline due to bazelbuild/bazel@3469784 (example failure)

What needs to be done: envoy-build-tools needs to be updated to use the latest rbe_config_gen from bazel-toolchains (at least version 5.1.2 so that it contains bazelbuild/bazel-toolchains@8c717f8). Then the toolchain configs need to be regenerated, and this file in Envoy needs to be updated so that Envoy uses the latest envoy-build-tools.

[phlax]

@Wyverald can you raise a PR in envoy-build-tools to update

[Wyverald]

sorry, I don't have the time. If you also can't find the cycles to do this, we'll have to disable Envoy in the downstream pipeline.

[mattklein123]

cc @lizan @keith

[keith]

working on this here envoyproxy/envoy-build-tools#181

[Wyverald]

gentle ping. Envoy remains broken in the downstream pipeline, and if we can't resolve that soon, we'd need to disable Envoy on Bazel CI.

[keith]

I submitted #22822 to unblock bazel CI

[keith]

@Wyverald can you confirm that fixes the next run?

[Wyverald]

The next run that includes that fix will be tonight CET, so I'll report back tomorrow. Thanks!

[Wyverald]

For some reason, Envoy is still broken: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/2601#0182d854-183d-4bcd-b15e-f60f99173f16

@aranguyen do you know why that may be? On line 279 of the logs, it says Inherited 'build' options: [...] --incompatible_use_platforms_repo_for_constraints=false, yet later the build still fails on @bazel_tools//platforms:X usages (line 292).

[aranguyen]

oh hmm..interesting..it looks like the flag did not get overriden somehow. The flag is in the workspace bazelrc file which should take precedence, unless there is something special about incompatible flag that prevent it from being overriden once flipped (I doubt it) that I do not know about. Let me take a look at that and file a bug with configurability team.

In the meantime, let me see if I can update the following to unblock the CI failures for envoy.

aranguyen-macbookpro:envoy aranguyen$ grep -r "@bazel_tools//platforms" /private/var/tmp/_bazel_aranguyen/d62ce45fc2cda7024a6d68c3c63b8002
/private/var/tmp/_bazel_aranguyen/d62ce45fc2cda7024a6d68c3c63b8002/external/io_bazel_rules_go/go/toolchain/toolchains.bzl:    @bazel_tools//platforms:default_platform will be used most of the time).
/private/var/tmp/_bazel_aranguyen/d62ce45fc2cda7024a6d68c3c63b8002/external/com_google_protobuf/third_party/googletest/BUILD.bazel:    constraint_values = ["@bazel_tools//platforms:windows"],
/private/var/tmp/_bazel_aranguyen/d62ce45fc2cda7024a6d68c3c63b8002/external/com_google_googletest/BUILD.bazel:    constraint_values = ["@bazel_tools//platforms:windows"],

[keith]

gtest update is here: #22779, blocked on unrelated issues
bazel toolchains PR is here: envoyproxy/envoy-build-tools#181 was blocked on a windows issue that should be fixed now, so maybe that one will be mergeable today

[keith]

#22862

[keith]

still needs #22978 or #22779

[meteorcloudy]

https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/1256#_

Can we get the gtest fixes merged? Envoy is one of the few projects that're blocking the flip of bazelbuild/bazel#8622

[keith]

I've submitted #23140 to just try to patch it, since updating googletest has some breaking changes it seems like. @meteorcloudy as stated above we are disabling this feature

envoy/.bazelrc

Lines 17 to 18 in aa1c71d

	# TODO: https://github.com/envoyproxy/envoy/issues/22758
	build --incompatible_use_platforms_repo_for_constraints=false

which clearly isn't taking, which sounds a bit risky for actually shipping a bazel update where folks can't disable it