Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Envoy should NACK an EDS update with duplicate addresses #23445

Open
markdroth opened this issue Oct 11, 2022 · 2 comments
Open

Envoy should NACK an EDS update with duplicate addresses #23445

markdroth opened this issue Oct 11, 2022 · 2 comments
Assignees
@wbpcode
Labels
area/eds bug help wanted Needs help!

Comments

@markdroth
Copy link
Contributor

Currently, if there are multiple addresses in the same EDS resource, Envoy will ignore all but the first occurrance. This behavior seems fairly arbitrary and surprising, especially because the different occurrances of the address could be in different localities or priorities.

I think in this case, Envoy should NACK the EDS update.

CC @kyessenov
@markdroth markdroth added bug triage Issue requires triage labels Oct 11, 2022
This was referenced Oct 11, 2022
Merged
Merged
@wbpcode wbpcode added area/eds and removed triage Issue requires triage labels Oct 12, 2022
@wbpcode
Copy link
Member

wbpcode commented Oct 12, 2022

cc @mattklein123

@mattklein123 mattklein123 added the help wanted Needs help! label Oct 12, 2022
@wbpcode
Copy link
Member

wbpcode commented Oct 14, 2022

/assign

@wbpcode wbpcode mentioned this issue Nov 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wbpcode wbpcode

Labels
area/eds bug help wanted Needs help!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattklein123 @wbpcode @markdroth