Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag --incompatible_config_setting_private_default_visibility will break Envoy in Bazel 7.0 #24183

Closed
keertk opened this issue Nov 23, 2022 · 10 comments · Fixed by #24237
Closed

Flag --incompatible_config_setting_private_default_visibility will break Envoy in Bazel 7.0 #24183

keertk opened this issue Nov 23, 2022 · 10 comments · Fixed by #24237
Assignees
@keith
Labels
area/build stale stalebot believes this issue/PR has not been touched recently

Comments

@keertk
Copy link

keertk commented Nov 23, 2022 •
edited

Incompatible flag --incompatible_config_setting_private_default_visibility will be enabled by default in the next major release (Bazel 7.0), thus breaking Envoy. Please migrate to fix this and unblock the flip of this flag.

The flag is documented here: bazelbuild/bazel#12933.

Please check the following CI builds for build and test results:

Never heard of incompatible flags before? We have documentation that explains everything.
If you have any questions, please file an issue in https://github.com/bazelbuild/continuous-integration.
@keertk keertk added the triage Issue requires triage label Nov 23, 2022
@keertk keertk mentioned this issue Nov 23, 2022
Open
@wbpcode wbpcode added area/build and removed triage Issue requires triage labels Nov 24, 2022
@wbpcode
Copy link
Member

wbpcode commented Nov 24, 2022

Hi, @keith could you take a look for this when you have free time? Thanks.

@keith keith self-assigned this Nov 28, 2022
keith added a commit to keith/envoy that referenced this issue Nov 29, 2022
@keith
bazel: fix config_setting visibility issues
239318f 
This pulls in a googleurl patch that's waiting on upstream, and updates
rules_go for compatibility with this flag. This also flips it early so
we don't regress before it's flipped upstream.

Fixes envoyproxy#24183

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
@keith keith mentioned this issue Nov 29, 2022
Merged
@keith
Copy link
Member

keith commented Nov 29, 2022

WIP here #24237

keith added a commit that referenced this issue Nov 29, 2022
@keith
bazel: fix config_setting visibility issues (#24237)
eb41b78 
This pulls in a googleurl patch that's waiting on upstream, and updates
rules_go for compatibility with this flag. This also flips it early so
we don't regress before it's flipped upstream.

Fixes #24183

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
@keertk keertk changed the title Flag --incompatible_config_setting_private_default_visibility will break Envoy in a future Bazel release Flag --incompatible_config_setting_private_default_visibility will break Envoy in Bazel 7.0 Nov 29, 2022
@meteorcloudy
Copy link
Contributor

The fix didn't get into downstream because https://buildkite.com/bazel/envoy/builds/2118#01849d85-5a46-4688-9dc4-2e30d6659b1b is failing and prevented the update of last green commit for Envoy.

@keith
Copy link
Member

keith commented Nov 30, 2022

#24270

@keith keith reopened this Nov 30, 2022
@keith
Copy link
Member

keith commented Nov 30, 2022

looking at the build failure, interesting that it's hit there but not on our CI, maybe a compiler version difference

@keith
Copy link
Member

keith commented Nov 30, 2022

the actual build failure is #23891

@botengyao
Copy link
Member

We can keep track of this issue here: google/tcmalloc#148

@keith
Copy link
Member

keith commented Nov 30, 2022

bumping the clang version for bazel CI here bazelbuild/continuous-integration#1502

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Dec 30, 2022
@keith
Copy link
Member

keith commented Jan 3, 2023

fixed by #24296

@keith keith closed this as completed Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keith keith

Labels
area/build stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bazel: fix config_setting visibility issues keith/envoy
5 participants
@keith @meteorcloudy @wbpcode @botengyao @keertk