Logging to syslog #242
Labels
enhancement
Feature requests. Not bugs or questions.
stale
stalebot believes this issue/PR has not been touched recently
Comments
mattklein123
added
enhancement
|
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions. |
stale
bot
added
the
stale
|
This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions. |
duderino
referenced
this issue
in duderino/envoy
Oct 12, 2019
…tio#242) Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora
pushed a commit
to PiotrSikora/envoy
that referenced
this issue
Aug 2, 2020
* Add Connection ID as property token (envoyproxy#583) Signed-off-by: gargnupur <gargnupur@google.com> * Update validation in Inline DNS table (envoyproxy#11897) (envoyproxy#584) Signed-off-by: Shriram Rajagopalan <rshriram@tetrate.io> Signed-off-by: Yuchen Dai <silentdai@gmail.com> Co-authored-by: Shriram Rajagopalan <rshriram@users.noreply.github.com> * build: make emscripten stable (envoyproxy#588) Signed-off-by: Lizan Zhou <lizan@tetrate.io> Co-authored-by: Nupur Garg <37600866+gargnupur@users.noreply.github.com> Co-authored-by: Shriram Rajagopalan <rshriram@users.noreply.github.com> Co-authored-by: Lizan Zhou <lizan@tetrate.io>
jpsim
pushed a commit
that referenced
this issue
Nov 28, 2022
Introduces request interfaces for the Swift library.
**Builder pattern**
We elected to use a builder pattern for the following reasons:
- Allows us to avoid making all properties mutable (such as those on `Request`). This is especially valuable because these types are classes instead of structs due to the fact that they need to be visible to Objective-C from Swift
- Provides a clear separation between mutable/immutable states of these types since only builders can be modified
- Allows consumers to easily convert between builders and the models, which will become particularly useful when we introduce features such as runtime filters in the future:
```swift
func filter(request: Request) -> Request {
return request
.newBuilder()
.addHeader(name: "x-new-header", value: "foo")
.build()
}
```
**Swift example**
```swift
let request = RequestBuilder(method: .post, url: url)
.addBody(data)
.addHeader(name: "x-some-header", value: "foo")
.addTrailer(name: "x-some-trailer", value: "foo")
.build()
```
**Objective-C example**
```objc
Request *request = [Request withMethod:RequestMethodGet url:url build:^(RequestBuilder *builder) {
[builder addBody:bodyData];
[builder addHeaderWithName:@"x-some-header" value:@"foo"];
[builder addTrailerWithName:@"x-some-trailer" value:@"foo"];
}];
```
**Notes**
- `NSObject` and `@objc` classes had to be used in order for these types to be visible to Objective-C
- Enums had to inherit from `Int` to be visible to Objective-C
Resolves envoyproxy/envoy-mobile#122
Signed-off-by: Michael Rebello <mrebello@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this issue
Nov 29, 2022
Introduces request interfaces for the Swift library.
**Builder pattern**
We elected to use a builder pattern for the following reasons:
- Allows us to avoid making all properties mutable (such as those on `Request`). This is especially valuable because these types are classes instead of structs due to the fact that they need to be visible to Objective-C from Swift
- Provides a clear separation between mutable/immutable states of these types since only builders can be modified
- Allows consumers to easily convert between builders and the models, which will become particularly useful when we introduce features such as runtime filters in the future:
```swift
func filter(request: Request) -> Request {
return request
.newBuilder()
.addHeader(name: "x-new-header", value: "foo")
.build()
}
```
**Swift example**
```swift
let request = RequestBuilder(method: .post, url: url)
.addBody(data)
.addHeader(name: "x-some-header", value: "foo")
.addTrailer(name: "x-some-trailer", value: "foo")
.build()
```
**Objective-C example**
```objc
Request *request = [Request withMethod:RequestMethodGet url:url build:^(RequestBuilder *builder) {
[builder addBody:bodyData];
[builder addHeaderWithName:@"x-some-header" value:@"foo"];
[builder addTrailerWithName:@"x-some-trailer" value:@"foo"];
}];
```
**Notes**
- `NSObject` and `@objc` classes had to be used in order for these types to be visible to Objective-C
- Enums had to inherit from `Int` to be visible to Objective-C
Resolves envoyproxy/envoy-mobile#122
Signed-off-by: Michael Rebello <mrebello@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
|
So does Envoy support syslog now? Could someone show me an example? |
arminabf
pushed a commit
to arminabf/envoy
that referenced
this issue
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It would be nice to be able to send access logs directly to a syslog server, making it easier to centralize logs.
The text was updated successfully, but these errors were encountered: