Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Attributes connection.transport_failure_reason #26710

Closed
XinyiZhangAws opened this issue Apr 12, 2023 · 4 comments · Fixed by #31058
Closed

Add Attributes connection.transport_failure_reason #26710

XinyiZhangAws opened this issue Apr 12, 2023 · 4 comments · Fixed by #31058
Labels
area/access_log help wanted Needs help!

Comments

@XinyiZhangAws
Copy link
Contributor

Title: Add Attributes connection.transport_failure_reason along with TLS connection errors

Description:

Describe the desired behavior, what scenario it enables and how it
would be used.
Purposed Attributes
connection.transport_failure_reason:
Currently upstream.transport_failure_reason is included in the attributes to indicate the upstream transport failure such as certificate validation failed. But there's no similar ones for downstream connection. Considering recent PR added downstream transport failure reason to access log, it can be added to attributes as well for consistency.

[optional Relevant Links:]

Any extra documentation required to understand the issue.
https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/advanced/attributes.html#attributes
https://github.com/envoyproxy/envoy/pull/25322/files
@XinyiZhangAws XinyiZhangAws added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Apr 12, 2023
@mattklein123 mattklein123 added area/access_log and removed enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Apr 14, 2023
@mattklein123
Copy link
Member

cc @kyessenov

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label May 14, 2023
@github-actions
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2023
@ytsssun
Copy link

ytsssun commented Jun 5, 2023

@mattklein123 could you add a "help wanted" tag to revive this issue?

@mattklein123 mattklein123 reopened this Jun 5, 2023
@mattklein123 mattklein123 added help wanted Needs help! and removed stale stalebot believes this issue/PR has not been touched recently labels Jun 5, 2023
@suniltheta suniltheta mentioned this issue Nov 27, 2023
Merged
kyessenov pushed a commit that referenced this issue Nov 29, 2023
@suniltheta @XinyiZhangAws
attributes: expose DOWNSTREAM_TRANSPORT_FAILURE_REASON as connection …
6b4c8f0 
…attribute (#31058)

Co-authored-by: Xinyi Zhang <zhaxny@amazon.com>
Reviving: #29180

Commit Message: attributes: expose DOWNSTREAM_TRANSPORT_FAILURE_REASON as connection attribute

Additional Description: Earlier PR #25322 added `DOWNSTREAM_TRANSPORT_FAILURE_REASON` to access log. This PR exposes it to be one of the attributes that other extension can have access to such as WASM filter. This attribute would play as a similar role to `upstream.transport_failure_reason` from upstream attributes.

Risk Level: Low
Testing: Unit testing
Docs Changes: Yes
Release Notes: Yes
Platform Specific Features:
Fixes: #26710
@liubnu liubnu mentioned this issue Apr 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/access_log help wanted Needs help!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

attributes: expose DOWNSTREAM_TRANSPORT_FAILURE_REASON as connection attribute suniltheta/envoy
3 participants
@mattklein123 @XinyiZhangAws @ytsssun