Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis: add support for stream commands (xread, xadd etc) #32928

Closed
danielnorberg opened this issue Mar 15, 2024 · 3 comments
Closed

redis: add support for stream commands (xread, xadd etc) #32928

danielnorberg opened this issue Mar 15, 2024 · 3 comments
Labels
area/redis enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently

Comments

@danielnorberg
Copy link
Contributor

danielnorberg commented Mar 15, 2024

Title: Redis stream command support

Description:
Envoy should proxy stream commands instead of responding "unsupported command".

This would be useful when utilizing redis streams via an envoy proxy.

Most of the stream commands only take a single key and can be trivially routed to the appropriate shard.

Some stream commands (e.g. XREAD and XREADGROUP) take multiple keys. A reasonable behavior could be to route the entire command to the shard corresponding to the first key in the arguments. Cluster-mode redis instances will reject commands where not all keys map to the same shard. However, non-cluster mode redis instances (sharded over by envoy) would not reject such commands. To catch this case envoy itself would need to verify that all keys of the command shard to the same instance.

Relevant Links:

@danielnorberg danielnorberg added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Mar 15, 2024
@nezdolik nezdolik added area/redis and removed triage Issue requires triage labels Mar 16, 2024
@nezdolik
Copy link
Member

cc @msukalski @weisisea

Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Apr 16, 2024
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redis enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

2 participants