filter-network-redis: add support for single-key STREAM commands #33436
Conversation
Signed-off-by: Nick Cooper <nick@not.fun>
|
Hi @nicknotfun, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
/assign-from @envoyproxy/first-pass-reviewers |
|
@envoyproxy/first-pass-reviewers assignee is @nezdolik |
|
Looks like the formatting of this PR needs to be fixed: |
There was a problem hiding this comment.
Looks like the testing of supported commands is covered by existing tests (by using values in simpleCommands() set as test input parameters). The format needs to be fixed, so that CI passes and changelog needs to be updated. Besides that, please update the supported commands table in the user docs: https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/other_protocols/redis
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
github-actions
bot
added
the
stale
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
) Commit Message: Add support for all the stream commands which are hashable on their first argument (the key) Additional Description: This is a repeat of #33436 which I sadly let get stale before following up on responses. Risk Level: Low Testing: Manual, also covered by existing tests Docs Changes: Added additional commands in the docs. Release Notes: Added to release notes. Platform Specific Features: N/A Signed-off-by: Nick Cooper <nick@not.fun>
Commit Message:
Add support for all the stream commands which are hashable on their first argument (the key)
Additional Description:
As above, it does lack support for the remaining stream commands which someone else can look at adding.
Is a partial fix for #32928
Risk Level: Low
Testing: Manual (unsure what is needed)
Docs Changes:
Probably should add to the supported command list, but want to ensure if the process is needed.
Release Notes:
Add support for xack, xadd, xautoclaim, xclaim, xdel, xlen, xrange, xrevrange, xtrim to the redis proxy.
Platform Specific Features: N/A